♻️ Clean CoreQSPI and CoreFlash #355

YannLocatelli · 2021-10-07T15:40:49Z

No description provided.

spikes/lk_flash_memory/main.cpp

codecov · 2021-10-07T16:06:03Z

Codecov Report

Merging #355 (32c1b34) into develop (0600f8c) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 32c1b34 differs from pull request most recent head cd32423. Consider uploading reports for the commit cd32423 to get more accurate results

@@            Coverage Diff            @@
##           develop      #355   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         1092      1064   -28     
=========================================
- Hits          1092      1064   -28

Impacted Files	Coverage Δ
...vers/CoreFlashMemory/include/CoreFlashIS25LP016D.h	`100.00% <ø> (ø)`
drivers/CoreQSPI/include/CoreQSPI.h	`100.00% <ø> (ø)`
include/interface/drivers/QSPI.h	`100.00% <ø> (ø)`
...ers/CoreFlashMemory/source/CoreFlashIS25LP016D.cpp	`100.00% <100.00%> (ø)`
drivers/CoreQSPI/source/CoreQSPI.cpp	`100.00% <100.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0600f8c...cd32423. Read the comment docs.

ladislas

LGTM 👍

Remove DataTransmissionFormat struct and use only 1 configuration

bt_lcd_qspi_rfid_touch_wifi only

sonarcloud · 2021-10-11T10:18:40Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

88.9% Coverage
0.0% Duplication

github-actions · 2021-10-11T10:21:16Z

.map & .bin files analysis report

Versions 🔖

base: develop / 4ef24a0 + mbed-os-6.15.0 + -std=c++17
head: yann/feature/qspi/clean-coreqspi-and-coreflash / cd32423 + mbed-os-6.15.0 + -std=c++17
toolchain: GNU Arm Embedded Toolchain 10.3-2021.07 - 10.3.1 20210621

Summary 📝

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Static RAM (base/head)	Static RAM Δ	Total Flash (base/head)	Total Flash Δ
LekaOS	✔️	✅	✅	12736 / 12736	ø	78324 / 78324	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	30496 / 30496	ø	229264 / 229264	ø
certs_emc_ble_led_motors	✔️	✅	✅	25400 / 25400	ø	181812 / 181812	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	❌	❌	23152 / 23104	📉 -48	148956 / 149996	📈 1040
certs_emc_lcd_led_motors	✔️	✅	✅	15880 / 15880	ø	85080 / 85080	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	24808 / 24808	ø	177900 / 177900	ø
spike_lk_ble	✔️	✅	✅	24112 / 24112	ø	175404 / 175404	ø
spike_lk_bluetooth	✔️	✅	✅	12736 / 12736	ø	81332 / 81332	ø
spike_lk_cg_animations	✔️	✅	✅	25728 / 25728	ø	135120 / 135120	ø
spike_lk_file_manager	✔️	✅	✅	15176 / 15176	ø	117180 / 117180	ø
spike_lk_flash_memory	✔️	❌	❌	12776 / 12776	ø	83124 / 82932	📉 -192
spike_lk_lcd	✔️	✅	✅	25352 / 25352	ø	131480 / 131480	ø
spike_lk_led	✔️	✅	✅	14656 / 14656	ø	83572 / 83572	ø
spike_lk_log_kit	✔️	✅	✅	12928 / 12928	ø	80564 / 80564	ø
spike_lk_motors	✔️	✅	✅	12816 / 12816	ø	81460 / 81460	ø
spike_lk_qspi	⚰️	-	-	-	-	-	-
spike_lk_rfid	✔️	✅	✅	12736 / 12736	ø	81076 / 81076	ø
spike_lk_sensors_battery	✔️	✅	✅	15392 / 15392	ø	119624 / 119624	ø
spike_lk_sensors_light	✔️	✅	✅	12776 / 12776	ø	80116 / 80116	ø
spike_lk_sensors_microphone	✔️	✅	✅	12776 / 12776	ø	80308 / 80308	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	12760 / 12760	ø	86388 / 86388	ø
spike_lk_sensors_touch	✔️	✅	✅	12888 / 12888	ø	88436 / 88436	ø
spike_lk_wifi	✔️	✅	✅	16096 / 16096	ø	125660 / 125660	ø
spike_mbed_blinky	✔️	✅	✅	11120 / 11120	ø	54736 / 54736	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	12840 / 12840	ø	78388 / 78388	ø
spike_stl_cxxsupport	✔️	✅	✅	12800 / 12800	ø	79796 / 79796	ø

Map files diff output 🗺️

Click to show diff list

certs_emc_bt_lcd_qspi_rfid_touch_wifi (click to expand)

--- _build_tmp/4ef24a0/certs_emc_bt_lcd_qspi_rfid_touch_wifi.txt	2021-10-11 10:21:04.253917310 +0000
+++ _build_tmp/cd32423/certs_emc_bt_lcd_qspi_rfid_touch_wifi.txt	2021-10-11 10:21:04.533918739 +0000
@@ -1,23 +1,25 @@
-| Module                 |           .text |       .data |          .bss |
-|------------------------|-----------------|-------------|---------------|
-| [fill]                 |       286(+286) |     10(+10) |       38(+38) |
-| [lib]/HelloWorld.a     |         94(+94) |       0(+0) |         0(+0) |
-| [lib]/LogKit.a         |       658(+658) |       0(+0) |       64(+64) |
-| [lib]/_LekaBluetooth.a |       968(+968) |       0(+0) |         0(+0) |
-| [lib]/_LekaFirmware.a  |       554(+554) |       0(+0) |         0(+0) |
-| [lib]/_LekaRFID.a      |       806(+806) |       0(+0) |         0(+0) |
-| [lib]/_LekaScreen.a    |     3166(+3166) |       0(+0) |     240(+240) |
-| [lib]/_LekaTouch.a     |     1946(+1946) |       8(+8) |     672(+672) |
-| [lib]/_LekaWifi.a      |       444(+444) |       0(+0) |         0(+0) |
-| [lib]/c.a              |   49324(+49324) | 2474(+2474) |       58(+58) |
-| [lib]/gcc.a            |     7416(+7416) |       0(+0) |         0(+0) |
-| [lib]/m.a              |       372(+372) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a |   72842(+72842) |   544(+544) | 11535(+11535) |
-| [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
-| [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a         |     5336(+5336) |       8(+8) |       44(+44) |
-| main.cpp.obj           |     1476(+1476) |       0(+0) |   7425(+7425) |
-| Subtotals              | 145908(+145908) | 3048(+3048) | 20104(+20104) |
-Total Static RAM memory (data + bss): 23152(+23152) bytes
-Total Flash memory (text + data): 148956(+148956) bytes
+| Module                  |           .text |       .data |          .bss |
+|-------------------------|-----------------|-------------|---------------|
+| CoreFlashUtils.cpp.obj  |       388(+388) |       9(+9) |     276(+276) |
+| [fill]                  |       282(+282) |     17(+17) |       38(+38) |
+| [lib]/CoreFlashMemory.a |       534(+534) |       0(+0) |         0(+0) |
+| [lib]/CoreQSPI.a        |       156(+156) |       0(+0) |         0(+0) |
+| [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
+| [lib]/LogKit.a          |       658(+658) |       0(+0) |       64(+64) |
+| [lib]/_LekaBluetooth.a  |       968(+968) |       0(+0) |         0(+0) |
+| [lib]/_LekaRFID.a       |       806(+806) |       0(+0) |         0(+0) |
+| [lib]/_LekaScreen.a     |     3166(+3166) |       0(+0) |     240(+240) |
+| [lib]/_LekaTouch.a      |     1726(+1726) |       0(+0) |     128(+128) |
+| [lib]/_LekaWifi.a       |       444(+444) |       0(+0) |         0(+0) |
+| [lib]/c.a               |   49324(+49324) | 2474(+2474) |       58(+58) |
+| [lib]/gcc.a             |     7416(+7416) |       0(+0) |         0(+0) |
+| [lib]/m.a               |       372(+372) |       0(+0) |         0(+0) |
+| [lib]/mbed-os-static.a  |   73086(+73086) |   544(+544) | 11535(+11535) |
+| [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
+| [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
+| [lib]/stdc++.a          |     5336(+5336) |       8(+8) |       44(+44) |
+| main.cpp.obj            |     1956(+1956) |       8(+8) |   7629(+7629) |
+| Subtotals               | 146932(+146932) | 3064(+3064) | 20040(+20040) |
+Total Static RAM memory (data + bss): 23104(+23104) bytes
+Total Flash memory (text + data): 149996(+149996) bytes

spike_lk_flash_memory (click to expand)

--- _build_tmp/4ef24a0/spike_lk_flash_memory.txt	2021-10-11 10:21:08.001936412 +0000
+++ _build_tmp/cd32423/spike_lk_flash_memory.txt	2021-10-11 10:21:08.229937574 +0000
@@ -1,19 +1,19 @@
 | Module                  |         .text |       .data |        .bss |
 |-------------------------|---------------|-------------|-------------|
-| [fill]                  |     160(+160) |       8(+8) |     20(+20) |
-| [lib]/CoreFlashMemory.a |     682(+682) |       0(+0) |       0(+0) |
-| [lib]/CoreQSPI.a        |     276(+276) |       0(+0) |       0(+0) |
+| [fill]                  |     136(+136) |       8(+8) |     20(+20) |
+| [lib]/CoreFlashMemory.a |     594(+594) |       0(+0) |       0(+0) |
+| [lib]/CoreQSPI.a        |     200(+200) |       0(+0) |       0(+0) |
 | [lib]/HelloWorld.a      |       94(+94) |       0(+0) |       0(+0) |
 | [lib]/LogKit.a          |     658(+658) |       0(+0) |     64(+64) |
 | [lib]/c.a               | 33296(+33296) | 2472(+2472) |     58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |       0(+0) |
 | [lib]/m.a               |     360(+360) |       0(+0) |       0(+0) |
 | [lib]/mbed-os-static.a  | 30950(+30950) |   444(+444) | 8178(+8178) |
 | [lib]/misc              |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |       0(+0) |
 | [lib]/stdc++.a          |   5336(+5336) |       8(+8) |     44(+44) |
-| main.cpp.obj            |   1000(+1000) |       8(+8) | 1440(+1440) |
-| Subtotals               | 80180(+80180) | 2944(+2944) | 9832(+9832) |
+| main.cpp.obj            |     996(+996) |       8(+8) | 1440(+1440) |
+| Subtotals               | 79988(+79988) | 2944(+2944) | 9832(+9832) |
 Total Static RAM memory (data + bss): 12776(+12776) bytes
-Total Flash memory (text + data): 83124(+83124) bytes
+Total Flash memory (text + data): 82932(+82932) bytes

YannLocatelli added 3 commits October 7, 2021 16:19

🔥 (qspi): Remove almost empty qspi spike

eb7a4a2

🔥 (is25lp): Remove SPIMode and ReadMode

3612b7a

🔥 (qspi): Remove alternate-byte phase parameter

f1c517b

YannLocatelli requested a review from ladislas October 7, 2021 15:40

YannLocatelli self-assigned this Oct 7, 2021

YannLocatelli commented Oct 7, 2021

View reviewed changes

spikes/lk_flash_memory/main.cpp Outdated Show resolved Hide resolved

YannLocatelli force-pushed the yann/feature/qspi/clean-coreqspi-and-coreflash branch 4 times, most recently from 32c1b34 to 8d78a68 Compare October 7, 2021 23:37

YannLocatelli marked this pull request as ready for review October 7, 2021 23:37

ladislas approved these changes Oct 10, 2021

View reviewed changes

YannLocatelli force-pushed the yann/feature/qspi/clean-coreqspi-and-coreflash branch 2 times, most recently from a4b0c77 to 0c405ae Compare October 11, 2021 10:06

YannLocatelli added 3 commits October 11, 2021 12:14

🔥 (qspi): Simplify setDataTransmissionFormat

3e457dd

Remove DataTransmissionFormat struct and use only 1 configuration

♻️ (emc): Modernize certification emc test

f282665

bt_lcd_qspi_rfid_touch_wifi only

🔥 (qspi): Remove LekaFirmware, old Flash control via QSPI

cd32423

YannLocatelli force-pushed the yann/feature/qspi/clean-coreqspi-and-coreflash branch from 0c405ae to cd32423 Compare October 11, 2021 10:14

ladislas merged commit 103c9f5 into develop Oct 11, 2021

ladislas deleted the yann/feature/qspi/clean-coreqspi-and-coreflash branch October 18, 2021 10:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

♻️ Clean CoreQSPI and CoreFlash #355

♻️ Clean CoreQSPI and CoreFlash #355

YannLocatelli commented Oct 7, 2021

codecov bot commented Oct 7, 2021 •

edited

Loading

ladislas left a comment

sonarcloud bot commented Oct 11, 2021 •

edited

Loading

github-actions bot commented Oct 11, 2021

♻️ Clean CoreQSPI and CoreFlash #355

♻️ Clean CoreQSPI and CoreFlash #355

Conversation

YannLocatelli commented Oct 7, 2021

codecov bot commented Oct 7, 2021 • edited Loading

Codecov Report

ladislas left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Oct 11, 2021 • edited Loading

github-actions bot commented Oct 11, 2021

.map & .bin files analysis report

Versions 🔖

Summary 📝

Map files diff output 🗺️

codecov bot commented Oct 7, 2021 •

edited

Loading

sonarcloud bot commented Oct 11, 2021 •

edited

Loading