Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♿ (file): Add is_open in interface::File #361

Merged
merged 1 commit into from
Oct 15, 2021

Conversation

YannLocatelli
Copy link
Member

No description provided.

@YannLocatelli
Copy link
Member Author

La méthode is_open() peut être utilisée dans le transfert d'un fichier vers la mémoire flash externe #360

Elle était utilisée jusque là uniquement pour les tests (stubs like).

@YannLocatelli YannLocatelli force-pushed the yann/feature/file-add_is_open_in_interface branch from 1b930ce to ab2c9fb Compare October 15, 2021 14:44
@codecov
Copy link

codecov bot commented Oct 15, 2021

Codecov Report

Merging #361 (ab2c9fb) into develop (b1eefc4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #361   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         1032      1032           
=========================================
  Hits          1032      1032           
Impacted Files Coverage Δ
include/interface/platform/File.h 100.00% <ø> (ø)
libs/FileSystemKit/include/FileSystemKit.h 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1eefc4...ab2c9fb. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Oct 15, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@github-actions
Copy link

.map & .bin files analysis report

Versions 🔖

Summary 📝

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Static RAM (base/head) Static RAM Δ Total Flash (base/head) Total Flash Δ
LekaOS ✔️ 12736 / 12736 ø 78324 / 78324 ø
bootloader ✔️ 23264 / 23264 ø 105992 / 105992 ø
certs_emc_ble_bt_lcd_led_motors ✔️ 30496 / 30496 ø 229264 / 229264 ø
certs_emc_ble_led_motors ✔️ 25400 / 25400 ø 181812 / 181812 ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 23104 / 23104 ø 149996 / 149996 ø
certs_emc_lcd_led_motors ✔️ 15880 / 15880 ø 85080 / 85080 ø
hardware_motors_test_reduction_and_wheels ✔️ 24808 / 24808 ø 177900 / 177900 ø
spike_lk_ble ✔️ 24112 / 24112 ø 175404 / 175404 ø
spike_lk_bluetooth ✔️ 12736 / 12736 ø 81332 / 81332 ø
spike_lk_cg_animations ✔️ 25728 / 25728 ø 135120 / 135120 ø
spike_lk_file_manager ✔️ 15176 / 15176 ø 117180 / 117180 ø
spike_lk_flash_memory ✔️ 12776 / 12776 ø 82932 / 82932 ø
spike_lk_lcd ✔️ 25352 / 25352 ø 131480 / 131480 ø
spike_lk_led ✔️ 14656 / 14656 ø 83572 / 83572 ø
spike_lk_log_kit ✔️ 12928 / 12928 ø 80564 / 80564 ø
spike_lk_motors ✔️ 12816 / 12816 ø 81460 / 81460 ø
spike_lk_rfid ✔️ 12736 / 12736 ø 81076 / 81076 ø
spike_lk_sensors_battery ✔️ 15392 / 15392 ø 119624 / 119624 ø
spike_lk_sensors_light ✔️ 12776 / 12776 ø 80116 / 80116 ø
spike_lk_sensors_microphone ✔️ 12776 / 12776 ø 80308 / 80308 ø
spike_lk_sensors_temperature_humidity ✔️ 12760 / 12760 ø 86388 / 86388 ø
spike_lk_sensors_touch ✔️ 12888 / 12888 ø 88436 / 88436 ø
spike_lk_update_process_app_base ✔️ 16536 / 16536 ø 134344 / 134408 📈 64
spike_lk_update_process_app_update ✔️ 13688 / 13688 ø 95680 / 95680 ø
spike_lk_wifi ✔️ 16096 / 16096 ø 125660 / 125660 ø
spike_mbed_blinky ✔️ 11120 / 11120 ø 54736 / 54736 ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 12840 / 12840 ø 78388 / 78388 ø
spike_stl_cxxsupport ✔️ 12800 / 12800 ø 79796 / 79796 ø

Map files diff output 🗺️

Click to show diff list
spike_lk_file_manager (click to expand)
--- _build_tmp/b1eefc4/spike_lk_file_manager.txt	2021-10-15 14:51:16.907019065 +0000
+++ _build_tmp/ab2c9fb/spike_lk_file_manager.txt	2021-10-15 14:51:17.143031184 +0000
@@ -1,19 +1,19 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
-| [fill]                 |       180(+180) |       4(+4) |       26(+26) |
+| [fill]                 |       170(+170) |       4(+4) |       26(+26) |
 | [lib]/FileManager.a    |       222(+222) |       0(+0) |         0(+0) |
-| [lib]/FileSystemKit.a  |       516(+516) |       0(+0) |         0(+0) |
+| [lib]/FileSystemKit.a  |       526(+526) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LogKit.a         |       658(+658) |       0(+0) |       64(+64) |
 | [lib]/c.a              |   47164(+47164) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a            |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a              |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a |   51006(+51006) |   460(+460) | 10229(+10229) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |     5336(+5336) |       8(+8) |       44(+44) |
 | main.cpp.obj           |     1220(+1220) |       8(+8) |   1632(+1632) |
 | Subtotals              | 114124(+114124) | 3056(+3056) | 12120(+12120) |
 Total Static RAM memory (data + bss): 15176(+15176) bytes
 Total Flash memory (text + data): 117180(+117180) bytes
 
spike_lk_update_process_app_base (click to expand)
--- _build_tmp/b1eefc4/spike_lk_update_process_app_base.txt	2021-10-15 14:51:21.699265115 +0000
+++ _build_tmp/ab2c9fb/spike_lk_update_process_app_base.txt	2021-10-15 14:51:21.927276821 +0000
@@ -1,21 +1,21 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       170(+170) |       0(+0) |       34(+34) |
+| [fill]                  |       224(+224) |       0(+0) |       34(+34) |
 | [lib]/CoreFlashMemory.a |       534(+534) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       156(+156) |       0(+0) |         0(+0) |
-| [lib]/FileSystemKit.a   |       516(+516) |       0(+0) |         0(+0) |
+| [lib]/FileSystemKit.a   |       526(+526) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LogKit.a          |       658(+658) |       0(+0) |       64(+64) |
 | [lib]/bootutil.a        |     1346(+1346) |     12(+12) |       92(+92) |
 | [lib]/c.a               |   48252(+48252) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  |   64768(+64768) |   524(+524) | 10385(+10385) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5336(+5336) |       8(+8) |       44(+44) |
 | main.cpp.obj            |     1658(+1658) |       8(+8) |   2664(+2664) |
-| Subtotals               | 131216(+131216) | 3128(+3128) | 13408(+13408) |
+| Subtotals               | 131280(+131280) | 3128(+3128) | 13408(+13408) |
 Total Static RAM memory (data + bss): 16536(+16536) bytes
-Total Flash memory (text + data): 134344(+134344) bytes
+Total Flash memory (text + data): 134408(+134408) bytes
 

@ladislas ladislas merged commit 53385bb into develop Oct 15, 2021
@ladislas ladislas deleted the yann/feature/file-add_is_open_in_interface branch October 15, 2021 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants