Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ (corevideo): Replace const struct with namespace for constexpr values #392

Merged

Conversation

ladislas
Copy link
Member

closes #156

@ladislas ladislas force-pushed the ladislas/feature/156-corevideo_config_struct_to_namespace branch from 60cad2e to ceee61e Compare December 13, 2021 14:15
@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #392 (ceee61e) into develop (172d2ab) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #392   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           65        65           
  Lines         1175      1174    -1     
=========================================
- Hits          1175      1174    -1     
Impacted Files Coverage Δ
drivers/CoreVideo/include/CGPixel.hpp 100.00% <100.00%> (ø)
drivers/CoreVideo/source/CoreDMA2D.cpp 100.00% <100.00%> (ø)
drivers/CoreVideo/source/CoreDSI.cpp 100.00% <100.00%> (ø)
drivers/CoreVideo/source/CoreFont.cpp 100.00% <100.00%> (ø)
drivers/CoreVideo/source/CoreGraphics.cpp 100.00% <100.00%> (ø)
drivers/CoreVideo/source/CoreLTDC.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172d2ab...ceee61e. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Dec 13, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@github-actions
Copy link

.map & .bin files analysis report

Versions 🔖

Summary 📝

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Static RAM (base/head) Static RAM Δ Total Flash (base/head) Total Flash Δ
LekaOS ✔️ 12736 / 12736 ø 78388 / 78388 ø
bootloader ✔️ 25912 / 25912 ø 88420 / 88420 ø
certs_emc_ble_bt_lcd_led_motors ✔️ 30496 / 30496 ø 229392 / 229392 ø
certs_emc_ble_led_motors ✔️ 25400 / 25400 ø 181876 / 181876 ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 23104 / 23104 ø 150252 / 150252 ø
certs_emc_lcd_led_motors ✔️ 15880 / 15880 ø 85144 / 85144 ø
hardware_motors_test_reduction_and_wheels ✔️ 24808 / 24808 ø 177964 / 177964 ø
spike_lk_ble ✔️ 24112 / 24112 ø 175468 / 175468 ø
spike_lk_bluetooth ✔️ 12736 / 12736 ø 81396 / 81396 ø
spike_lk_cg_animations ✔️ 25728 / 25728 ø 135248 / 135248 ø
spike_lk_file_manager ✔️ 15176 / 15176 ø 117372 / 117372 ø
spike_lk_file_reception ✔️ 20536 / 20536 ø 279896 / 279896 ø
spike_lk_flash_memory ✔️ 12776 / 12776 ø 83060 / 83060 ø
spike_lk_lcd ✔️ 25352 / 25352 ø 131608 / 131608 ø
spike_lk_led ✔️ 14656 / 14656 ø 83636 / 83636 ø
spike_lk_log_kit ✔️ 12928 / 12928 ø 80692 / 80692 ø
spike_lk_motors ✔️ 12816 / 12816 ø 81524 / 81524 ø
spike_lk_rfid ✔️ 12736 / 12736 ø 81140 / 81140 ø
spike_lk_sensors_battery ✔️ 12776 / 12776 ø 80628 / 80628 ø
spike_lk_sensors_light ✔️ 12776 / 12776 ø 80180 / 80180 ø
spike_lk_sensors_microphone ✔️ 12776 / 12776 ø 80436 / 80436 ø
spike_lk_sensors_temperature_humidity ✔️ 12760 / 12760 ø 86452 / 86452 ø
spike_lk_sensors_touch ✔️ 12888 / 12888 ø 88500 / 88500 ø
spike_lk_update_process_app_base ✔️ 16600 / 16600 ø 134920 / 134920 ø
spike_lk_update_process_app_update ✔️ 13728 / 13728 ø 95936 / 95936 ø
spike_lk_wifi ✔️ 16096 / 16096 ø 125788 / 125788 ø
spike_mbed_blinky ✔️ 11120 / 11120 ø 54800 / 54800 ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 12840 / 12840 ø 78452 / 78452 ø
spike_stl_cxxsupport ✔️ 12800 / 12800 ø 79860 / 79860 ø

Map files diff output 🗺️

Click to show diff list

No differenes where found in map files.

Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validé sur

  • Spike - CG animation
  • Spike - LCD

@ladislas ladislas merged commit 1ae6144 into develop Dec 16, 2021
@ladislas ladislas deleted the ladislas/feature/156-corevideo_config_struct_to_namespace branch December 16, 2021 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] - Replace struct of corevideo_config by namespace
2 participants