Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🩹 (std): Fix include replacing <cinttypes> with <cstdint> #398

Merged
merged 1 commit into from
Jan 5, 2022

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Jan 4, 2022

is a lot less known than .

is part of the type support library, providing fixed width
integer types and part of C numeric limits interface.

@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #398 (6985f08) into develop (ee66e0c) will not change coverage.
The diff coverage is n/a.

❗ Current head 6985f08 differs from pull request most recent head 0ec7280. Consider uploading reports for the commit 0ec7280 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #398   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        65    -3     
  Lines         1204      1195    -9     
=========================================
- Hits          1204      1195    -9     
Impacted Files Coverage Δ
libs/RobotKit/include/StateMachine.h
libs/RobotKit/include/interface/RobotController.h
libs/RobotKit/tests/mocks/RobotController.h

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee66e0c...0ec7280. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

File comparision analysis report

🔖 Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / 1f6f757 + mbed-os-6.15.1 + -std=c++20
  • head: ladislas/bugfix/include / 0ec7280 + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • ENABLE_LOG_DEBUG=ON

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 82200 (3%) ø 17472 (3%) ø
bootloader ✔️ 95024 (4%) ø 26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 251132 (11%) ø 36144 (6%) ø
certs_emc_ble_led_motors ✔️ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ 183688 (8%) ø 28856 (5%) ø
spike_lk_bluetooth ✔️ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ 149336 (7%) ø 30464 (5%) ø
spike_lk_file_manager ✔️ 132396 (6%) ø 19912 (3%) ø
spike_lk_file_reception ✔️ 333692 (15%) ø 25272 (4%) ø
spike_lk_flash_memory ✔️ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ 149808 (7%) ø 30088 (5%) ø
spike_lk_led ✔️ 88808 (4%) ø 19400 (3%) ø
spike_lk_log_kit ✔️ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ 85088 (4%) ø 17512 (3%) ø
spike_lk_sensors_light ✔️ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ 85516 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ 92248 (4%) ø 17632 (3%) ø
spike_lk_update_process_app_base ✔️ 144052 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ 101120 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ 84008 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

File comparision analysis report

🔖 Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / 1f6f757 + mbed-os-6.15.1 + -std=c++20
  • head: ladislas/bugfix/include / 0ec7280 + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • ENABLE_LOG_DEBUG=OFF

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 58328 (2%) ø 11400 (2%) ø
bootloader ✔️ 95024 (4%) ø 26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 234668 (11%) ø 30056 (5%) ø
certs_emc_ble_led_motors ✔️ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ 162616 (7%) ø 22792 (4%) ø
spike_lk_bluetooth ✔️ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ 141064 (6%) ø 24464 (4%) ø
spike_lk_file_manager ✔️ 109588 (5%) ø 13672 (2%) ø
spike_lk_file_reception ✔️ 328916 (15%) ø 19312 (3%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ 136928 (6%) ø 24016 (4%) ø
spike_lk_led ✔️ 65744 (3%) ø 13392 (2%) ø
spike_lk_log_kit ✔️ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ 60280 (2%) ø 11440 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72860 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_update_process_app_base ✔️ 121572 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ 77720 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

<cinttypes> is a lot less known than <cstdint>.

<cstdint> is part of the type support library, providing fixed width
integer types and part of C numeric limits interface.
@ladislas ladislas merged commit 1f6f757 into develop Jan 5, 2022
@ladislas ladislas deleted the ladislas/bugfix/include branch January 5, 2022 15:11
@sonarcloud
Copy link

sonarcloud bot commented Jan 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants