Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladislas/feature/deprecate lstd #402

Merged
merged 5 commits into from
Jan 9, 2022
Merged

ladislas/feature/deprecate lstd #402

merged 5 commits into from
Jan 9, 2022

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Jan 7, 2022

  • ๐Ÿ“Œ (cmake): Set unit tests CXX_STANDARD to 20
  • ๐Ÿ—‘๏ธ (std): Deprecate lstd_array
  • ๐Ÿ—‘๏ธ (std): Deprecate lstd_span

@ladislas ladislas force-pushed the ladislas/feature/deprecate-lstd branch from c985133 to 4d63fb7 Compare January 7, 2022 11:58
@github-actions
Copy link

github-actions bot commented Jan 7, 2022 •
edited
Loading

File comparision analysis report

๐Ÿ”– Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / 41893e2 + mbed-os-6.15.1 + -std=c++20
  • head: ladislas/feature/deprecate-lstd / b095afd + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • ENABLE_LOG_DEBUG=ON

๐Ÿ“ Summary

Click to show summary
  • โœ”๏ธ - existing target
  • โœจ - new target
  • โšฐ๏ธ - deleted target
  • โœ… - files are the same
  • โŒ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash ฮ” Static RAM (base/head) Static RAM ฮ”
LekaOS โœ”๏ธ โœ… โœ… 82200ย (3%) รธ 17472ย (3%) รธ
bootloader โœ”๏ธ โœ… โœ… 95024ย (4%) รธ 26200ย (4%) รธ
certs_emc_ble_bt_lcd_led_motors โœ”๏ธ โœ… โœ… 251132ย (11%) รธ 36144ย (6%) รธ
certs_emc_ble_led_motors โœ”๏ธ โœ… โœ… 191600ย (9%) รธ 30976ย (5%) รธ
certs_emc_bt_lcd_qspi_rfid_touch_wifi โœ”๏ธ โœ… โœ… 165248ย (7%) รธ 28680ย (5%) รธ
certs_emc_lcd_led_motors โœ”๏ธ โœ… โœ… 91928ย (4%) รธ 16168ย (3%) รธ
hardware_motors_test_reduction_and_wheels โœ”๏ธ โœ… โœ… 194032ย (9%) รธ 30384ย (5%) รธ
spike_lk_ble โœ”๏ธ โœ… โœ… 183688ย (8%) รธ 28856ย (5%) รธ
spike_lk_bluetooth โœ”๏ธ โœ… โœ… 91192ย (4%) รธ 17472ย (3%) รธ
spike_lk_cg_animations โœ”๏ธ โœ… โœ… 149336ย (7%) รธ 30464ย (5%) รธ
spike_lk_file_manager โœ”๏ธ โœ… โœ… 132396ย (6%) รธ 19912ย (3%) รธ
spike_lk_file_reception โœ”๏ธ โœ… โœ… 333692ย (15%) รธ 25272ย (4%) รธ
spike_lk_flash_memory โœ”๏ธ โœ… โœ… 87352ย (4%) รธ 17512ย (3%) รธ
spike_lk_lcd โœ”๏ธ โœ… โœ… 149808ย (7%) รธ 30088ย (5%) รธ
spike_lk_led โœ”๏ธ โœ… โœ… 88808ย (4%) รธ 19400ย (3%) รธ
spike_lk_log_kit โœ”๏ธ โœ… โœ… 92000ย (4%) รธ 18168ย (3%) รธ
spike_lk_motors โœ”๏ธ โœ… โœ… 86576ย (4%) รธ 17552ย (3%) รธ
spike_lk_rfid โœ”๏ธ โœ… โœ… 91008ย (4%) รธ 17472ย (3%) รธ
spike_lk_sensors_battery โœ”๏ธ โœ… โœ… 85088ย (4%) รธ 17512ย (3%) รธ
spike_lk_sensors_light โœ”๏ธ โœ… โœ… 84584ย (4%) รธ 17512ย (3%) รธ
spike_lk_sensors_microphone โœ”๏ธ โœ… โœ… 85516ย (4%) รธ 17512ย (3%) รธ
spike_lk_sensors_temperature_humidity โœ”๏ธ โœ… โœ… 90896ย (4%) รธ 17496ย (3%) รธ
spike_lk_sensors_touch โœ”๏ธ โœ… โœ… 92248ย (4%) รธ 17632ย (3%) รธ
spike_lk_update_process_app_base โœ”๏ธ โœ… โœ… 144052ย (6%) รธ 21352ย (4%) รธ
spike_lk_update_process_app_update โœ”๏ธ โœ… โœ… 101120ย (4%) รธ 18472ย (3%) รธ
spike_lk_wifi โœ”๏ธ โœ… โœ… 131280ย (6%) รธ 20832ย (3%) รธ
spike_mbed_blinky โœ”๏ธ โœ… โœ… 57968ย (2%) รธ 11400ย (2%) รธ
spike_mbed_watchdog_ticker_vs_thread โœ”๏ธ โœ… โœ… 84688ย (4%) รธ 18448ย (3%) รธ
spike_stl_cxxsupport โœ”๏ธ โŒ โœ… 84008ย (4%)
84000ย (4%)		 ๐Ÿ“‰
-8ย (0%)		 17536ย (3%) รธ

๐Ÿ—บ๏ธ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022 •
edited
Loading

File comparision analysis report

๐Ÿ”– Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / 41893e2 + mbed-os-6.15.1 + -std=c++20
  • head: ladislas/feature/deprecate-lstd / b095afd + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • ENABLE_LOG_DEBUG=OFF

๐Ÿ“ Summary

Click to show summary
  • โœ”๏ธ - existing target
  • โœจ - new target
  • โšฐ๏ธ - deleted target
  • โœ… - files are the same
  • โŒ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash ฮ” Static RAM (base/head) Static RAM ฮ”
LekaOS โœ”๏ธ โœ… โœ… 58328ย (2%) รธ 11400ย (2%) รธ
bootloader โœ”๏ธ โœ… โœ… 95024ย (4%) รธ 26200ย (4%) รธ
certs_emc_ble_bt_lcd_led_motors โœ”๏ธ โœ… โœ… 234668ย (11%) รธ 30056ย (5%) รธ
certs_emc_ble_led_motors โœ”๏ธ โœ… โœ… 174568ย (8%) รธ 24952ย (4%) รธ
certs_emc_bt_lcd_qspi_rfid_touch_wifi โœ”๏ธ โœ… โœ… 148840ย (7%) รธ 22528ย (4%) รธ
certs_emc_lcd_led_motors โœ”๏ธ โœ… โœ… 91928ย (4%) รธ 16168ย (3%) รธ
hardware_motors_test_reduction_and_wheels โœ”๏ธ โœ… โœ… 177960ย (8%) รธ 24360ย (4%) รธ
spike_lk_ble โœ”๏ธ โœ… โœ… 162616ย (7%) รธ 22792ย (4%) รธ
spike_lk_bluetooth โœ”๏ธ โœ… โœ… 73256ย (3%) รธ 11448ย (2%) รธ
spike_lk_cg_animations โœ”๏ธ โœ… โœ… 141064ย (6%) รธ 24464ย (4%) รธ
spike_lk_file_manager โœ”๏ธ โœ… โœ… 109588ย (5%) รธ 13672ย (2%) รธ
spike_lk_file_reception โœ”๏ธ โœ… โœ… 328916ย (15%) รธ 19312ย (3%) รธ
spike_lk_flash_memory โœ”๏ธ โœ… โœ… 63880ย (3%) รธ 11448ย (2%) รธ
spike_lk_lcd โœ”๏ธ โœ… โœ… 136928ย (6%) รธ 24016ย (4%) รธ
spike_lk_led โœ”๏ธ โœ… โœ… 65744ย (3%) รธ 13392ย (2%) รธ
spike_lk_log_kit โœ”๏ธ โœ… โœ… 68528ย (3%) รธ 11912ย (2%) รธ
spike_lk_motors โœ”๏ธ โœ… โœ… 62528ย (2%) รธ 11488ย (2%) รธ
spike_lk_rfid โœ”๏ธ โœ… โœ… 73072ย (3%) รธ 11448ย (2%) รธ
spike_lk_sensors_battery โœ”๏ธ โœ… โœ… 60280ย (2%) รธ 11440ย (2%) รธ
spike_lk_sensors_light โœ”๏ธ โœ… โœ… 60056ย (2%) รธ 11440ย (2%) รธ
spike_lk_sensors_microphone โœ”๏ธ โœ… โœ… 72860ย (3%) รธ 11504ย (2%) รธ
spike_lk_sensors_temperature_humidity โœ”๏ธ โœ… โœ… 66968ย (3%) รธ 11424ย (2%) รธ
spike_lk_sensors_touch โœ”๏ธ โœ… โœ… 68600ย (3%) รธ 11432ย (2%) รธ
spike_lk_update_process_app_base โœ”๏ธ โœ… โœ… 121572ย (5%) รธ 15288ย (2%) รธ
spike_lk_update_process_app_update โœ”๏ธ โœ… โœ… 77720ย (3%) รธ 12352ย (2%) รธ
spike_lk_wifi โœ”๏ธ โœ… โœ… 116392ย (5%) รธ 14808ย (2%) รธ
spike_mbed_blinky โœ”๏ธ โœ… โœ… 57968ย (2%) รธ 11400ย (2%) รธ
spike_mbed_watchdog_ticker_vs_thread โœ”๏ธ โœ… โœ… 63208ย (3%) รธ 12448ย (2%) รธ
spike_stl_cxxsupport โœ”๏ธ โœ… โœ… 58456ย (2%) รธ 11400ย (2%) รธ

๐Ÿ—บ๏ธ Map files diff output

Click to show diff list

No differenes where found in map files.

@codecov
Copy link

codecov bot commented Jan 7, 2022 •
edited
Loading

Codecov Report

Merging #402 (b095afd) into develop (41893e2) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #402   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        66    -2     
  Lines         1204      1188   -16     
=========================================
- Hits          1204      1188   -16
Impacted Files Coverage ฮ”
...vers/CoreFlashMemory/include/CoreFlashIS25LP016D.h 100.00% <รธ> (รธ)
drivers/CoreQSPI/include/CoreQSPI.h 100.00% <รธ> (รธ)
include/interface/drivers/FlashManager.h 100.00% <รธ> (รธ)
include/interface/drivers/FlashMemory.h 100.00% <รธ> (รธ)
include/interface/drivers/QSPI.h 100.00% <รธ> (รธ)
include/interface/platform/File.h 100.00% <รธ> (รธ)
libs/FileSystemKit/include/FileSystemKit.h 100.00% <รธ> (รธ)
libs/Utils/include/MathUtils.h 100.00% <รธ> (รธ)
...ers/CoreFlashMemory/source/CoreFlashIS25LP016D.cpp 100.00% <100.00%> (รธ)
drivers/CoreQSPI/source/CoreQSPI.cpp 100.00% <100.00%> (รธ)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
ฮ” = absolute <relative> (impact), รธ = not affected, ? = missing data
Powered by Codecov. Last update 41893e2...b095afd. Read the comment docs.

@ladislas ladislas force-pushed the ladislas/feature/deprecate-lstd branch from 6e4f3c9 to e14b11f Compare January 7, 2022 12:48
@ladislas ladislas force-pushed the ladislas/feature/deprecate-lstd branch from 9eccdf6 to b095afd Compare January 7, 2022 15:55
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!ย  ย  Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit e4c16f5 into develop Jan 9, 2022
YannLocatelli
YannLocatelli reviewed Jan 11, 2022
View reviewed changes
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validรฉ avec

  • Spike Flash memory
  • Spike LCD
  • Spike STLcxxsupport

@ladislas ladislas deleted the ladislas/feature/deprecate-lstd branch January 12, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannLocatelli YannLocatelli YannLocatelli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislas @YannLocatelli