Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladislas/feature/clean up cmake #403

Merged
merged 19 commits into from
Jan 12, 2022
Merged

ladislas/feature/clean up cmake #403

merged 19 commits into from
Jan 12, 2022

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Jan 7, 2022

  • 🔥 (cmake): Remove CODE_ANALYSIS
  • 🩹 (targets): Fix device names with good values from arm_pack_manager
  • 🗑️ (targets): Remove old unused dev hardware targets

@codecov
Copy link

codecov bot commented Jan 7, 2022 •
edited
Loading

Codecov Report

Merging #403 (8f2f5c2) into develop (a1d9812) will not change coverage.
The diff coverage is n/a.

❗ Current head 8f2f5c2 differs from pull request most recent head 202a6b1. Consider uploading reports for the commit 202a6b1 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #403   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        66           
  Lines         1188      1188           
=========================================
  Hits          1188      1188
Impacted Files Coverage Δ
libs/IOKit/include/DigitalIn.h 100.00% <0.00%> (ø)
libs/IOKit/include/internal/IO.h 100.00% <0.00%> (ø)
include/interface/drivers/IOExpander.h 100.00% <0.00%> (ø)
include/interface/drivers/BufferedSerial.h 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea62320...202a6b1. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / ea62320 + mbed-os-6.15.1 + -std=c++20
  • head: ladislas/feature/clean-up-cmake / 202a6b1 + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • ENABLE_LOG_DEBUG=OFF

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 58328 (2%) ø 11400 (2%) ø
bootloader ✔️ ✅ ✅ 95024 (4%) ø 26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 234668 (11%) ø 30056 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ ✅ ✅ 162616 (7%) ø 22792 (4%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 141064 (6%) ø 24464 (4%) ø
spike_lk_file_manager ✔️ ✅ ✅ 109588 (5%) ø 13672 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 328916 (15%) ø 19312 (3%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 136928 (6%) ø 24016 (4%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 60280 (2%) ø 11440 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72860 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 121572 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77720 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / ea62320 + mbed-os-6.15.1 + -std=c++20
  • head: ladislas/feature/clean-up-cmake / 202a6b1 + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • ENABLE_LOG_DEBUG=ON

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 82200 (3%) ø 17472 (3%) ø
bootloader ✔️ ✅ ✅ 95024 (4%) ø 26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 251132 (11%) ø 36144 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ ✅ ✅ 183688 (8%) ø 28856 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 149336 (7%) ø 30464 (5%) ø
spike_lk_file_manager ✔️ ✅ ✅ 132396 (6%) ø 19912 (3%) ø
spike_lk_file_reception ✔️ ✅ ✅ 333692 (15%) ø 25272 (4%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 149808 (7%) ø 30088 (5%) ø
spike_lk_led ✔️ ✅ ✅ 88808 (4%) ø 19400 (3%) ø
spike_lk_log_kit ✔️ ✅ ✅ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ ✅ ✅ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 85088 (4%) ø 17512 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 85516 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 92248 (4%) ø 17632 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 144052 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 101120 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@ladislas ladislas force-pushed the ladislas/feature/clean-up-cmake branch 11 times, most recently from 36aca72 to fd263f9 Compare January 8, 2022 13:23
@ladislas ladislas force-pushed the ladislas/feature/clean-up-cmake branch 6 times, most recently from 51e7747 to 7658d0a Compare January 11, 2022 13:12
YannLocatelli
YannLocatelli approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validé avec

  • Température
  • Flash memory
  • LEDs
  • LCD (avec std::span pour écrire du texte à l'écran
  • File reception (SD + wifi)
  • Update (bootloader&app + wifi + mcuboot)
  • tests/functional/cert/emc_bt_lcd_qspi_rfid_touch_wifi
  • Avec et Sans logs
  • Un test mis en échec

--

De manière générale, mentionner la motivation principale (ex. Pour la transition vers mbed cli 2)
Qu'est-ce qui fait sauter toute la compilation avec Arm, pourquoi le unit test ne procède plus de la même manière, pourquoi tant de fichier cmake disparaissent

.github/workflows/ci-code_analysis-compare_bin_map_files.yml Show resolved Hide resolved
CMakeLists.txt Outdated Show resolved Hide resolved
cmake/templates/Template_MbedOS_CMakelists.txt Show resolved Hide resolved
docs/INSTALL.md Outdated Show resolved Hide resolved
cmake/templates/mcuboot/mbed.cmake Outdated Show resolved Hide resolved
build_firmware.sh Show resolved Hide resolved
@ladislas ladislas force-pushed the ladislas/feature/clean-up-cmake branch 2 times, most recently from 8f2f5c2 to ddbb9f4 Compare January 12, 2022 10:01
YannLocatelli
YannLocatelli approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Validé avec

  • Update (bootloader&app + wifi + mcuboot)

@ladislas ladislas force-pushed the ladislas/feature/clean-up-cmake branch from ddbb9f4 to 1e1c286 Compare January 12, 2022 13:01
@ladislas
🔥 (cmake): Remove CODE_ANALYSIS
0a76530 
CODE_ANALYSIS was done using cppcheck. Now that we have SonarCloud, we
can remove local code analysis.
@ladislas
🩹 (targets): Fix device names with good values from arm_pack_manager
c96fc14
@ladislas
🗑️ (targets): Remove old unused dev hardware targets
572ea08
@ladislas
♻️ (cmake): Move mcuboot compile definitions to bootutil target
51cbd43 
Using target_compile_definitions instead of add_compile_definitions
prevents definitions from being applied to all targets.

This will allow us in the future to have different bootloaders if
needed.
@ladislas
🚚 (cmake): Move & rename mbed cmake templates
1d391f5
@ladislas
🚚 (cmake): Move & rename mcuboot cmake templates
e2dc6d2
@ladislas
💚 (cache): Pull extern deps when hash of template files has changed
be59abe
@ladislas
💚 (workflows): Curl extern deps if cache hit is false
eb47455
@ladislas
🔥 (cmake): Delete MbedUnitTests related code/files
004d441
@ladislas
🔥 (cmake): Delete unused USCRPL/mbed-cmake files
8bd9f7c
@ladislas
🔥 (cmake): Delete unused ArmClang toolchain files
c40150e
@ladislas
🔥 (cmake): Remove ArmClang code and branches
b5f34e3
@ladislas
💄 (cmake): Clean up main CMakeLists.txt
6e94d17
@ladislas
💄 (cmake): Clean up unit tests CMakeLists.txt
98b5780
@ladislas
🔨 (make): Add bootloader make target
4e69ee9
@ladislas
♻️ (scripts): Clean up firmware scripts
71e6eaf
@ladislas
🔧 (cmake/vscode): Fix build dirs + combine compilation databases
e302d67
@ladislas
🔨 (make): Add pull_deps target to clone mbed & mcuboot
31273c3
@ladislas
📝 (docs): Update & clean up install/how-to documentation
202a6b1 
- remove Linux/Ubuntu instructions
- fix typos, old links, etc.
- add vscode plugins and instructions
@ladislas ladislas force-pushed the ladislas/feature/clean-up-cmake branch from 1e1c286 to 202a6b1 Compare January 12, 2022 13:04
@sonarcloud
Copy link

sonarcloud bot commented Jan 12, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@ladislas ladislas merged commit 966dcd6 into develop Jan 12, 2022
@ladislas ladislas deleted the ladislas/feature/clean-up-cmake branch January 12, 2022 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannLocatelli YannLocatelli YannLocatelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladislas @YannLocatelli