Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ladislas/feature/logkit internal #430

Merged
merged 2 commits into from
Jan 20, 2022
Merged

ladislas/feature/logkit internal #430

merged 2 commits into from
Jan 20, 2022

Conversation

ladislas
Copy link
Member

  • ♻️ (libs): LogKit - move implementation details into internal namespace
  • 🔥 (libs): LogKit - remove redundant leka::logger namespace

@ladislas ladislas linked an issue Jan 19, 2022 that may be closed by this pull request
LogKit - hide implementation details #431
Closed
@codecov
Copy link

codecov bot commented Jan 19, 2022 •
edited
Loading

Codecov Report

Merging #430 (b53686f) into develop (d95ae59) will not change coverage.
The diff coverage is 100.00%.

❗ Current head b53686f differs from pull request most recent head be15c10. Consider uploading reports for the commit be15c10 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #430   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           68        66    -2     
  Lines         1193      1187    -6     
=========================================
- Hits          1193      1187    -6
Impacted Files Coverage Δ
libs/LogKit/include/LogKit.h 100.00% <100.00%> (ø)
drivers/CoreMicrophone/source/CoreMicrophone.cpp
drivers/CoreFs/include/CoreFatFsBase.h
drivers/CoreLightSensor/include/CoreLightSensor.h
drivers/CoreMicrophone/include/CoreMicrophone.h
drivers/CoreLL/include/CoreLL.h
drivers/CoreSTM32Hal/include/CoreSTM32HalBase.h
drivers/CoreLightSensor/source/CoreLightSensor.cpp
drivers/LKCoreLL/include/LKCoreLL.h 100.00% <0.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d95ae59...be15c10. Read the comment docs.

@ladislas ladislas force-pushed the ladislas/feature/logkit-internal branch 3 times, most recently from 920ccb7 to 3d3780a Compare January 19, 2022 15:23
@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / d95ae59 + mbed-os-6.15.1 + -std=c++20
  • head: ladislas/feature/logkit-internal / be15c10 + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: ON

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 82200 (3%) ø 17472 (3%) ø
bootloader ✔️ ✅ ✅ 93328 (4%) ø 26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 251644 (11%) ø 36144 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ ✅ ✅ 183688 (8%) ø 28856 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 149336 (7%) ø 30464 (5%) ø
spike_lk_file_manager ✔️ ✅ ✅ 125884 (6%) ø 19984 (3%) ø
spike_lk_file_reception ✔️ ✅ ✅ 333692 (15%) ø 25272 (4%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 149808 (7%) ø 30088 (5%) ø
spike_lk_led ✔️ ✅ ✅ 88808 (4%) ø 19400 (3%) ø
spike_lk_log_kit ✔️ ✅ ✅ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ ✅ ✅ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 85088 (4%) ø 17512 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 92248 (4%) ø 17632 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 143764 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ ❌ ✅ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented Jan 19, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

  • Flash: 2 097 152 Bytes (2048 KiB) / SRAM: 524 288 Bytes (512 KiB)
  • base: develop / d95ae59 + mbed-os-6.15.1 + -std=c++20
  • head: ladislas/feature/logkit-internal / be15c10 + mbed-os-6.15.1 + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: OFF

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 58328 (2%) ø 11400 (2%) ø
bootloader ✔️ ✅ ✅ 93328 (4%) ø 26200 (4%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 234668 (11%) ø 30056 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ ✅ ✅ 162616 (7%) ø 22792 (4%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 141064 (6%) ø 24464 (4%) ø
spike_lk_file_manager ✔️ ✅ ✅ 102036 (4%) ø 13672 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 328916 (15%) ø 19312 (3%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 136928 (6%) ø 24016 (4%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 60280 (2%) ø 11440 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 121348 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@ladislas ladislas force-pushed the ladislas/feature/logkit-internal branch from 3d3780a to 0bc61c4 Compare January 19, 2022 15:53
@ladislas ladislas self-assigned this Jan 19, 2022
YannLocatelli
YannLocatelli approved these changes Jan 19, 2022
View reviewed changes
Copy link
Member

@YannLocatelli YannLocatelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rien à dire, tout roule

@ladislas ladislas force-pushed the ladislas/feature/logkit-internal branch 3 times, most recently from bf7a3a7 to 3be66de Compare January 20, 2022 14:36
@ladislas ladislas force-pushed the ladislas/feature/logkit-internal branch from b53686f to be15c10 Compare January 20, 2022 22:03
@sonarcloud
Copy link

sonarcloud bot commented Jan 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

92.3% 92.3% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit fc3fe88 into develop Jan 20, 2022
@ladislas ladislas deleted the ladislas/feature/logkit-internal branch January 20, 2022 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YannLocatelli YannLocatelli YannLocatelli approved these changes

Assignees

@ladislas ladislas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

LogKit - hide implementation details
2 participants
@ladislas @YannLocatelli