Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚸 (battery): Charge input as InterruptIn #439

Merged
merged 4 commits into from
Jan 23, 2022
Merged

🚸 (battery): Charge input as InterruptIn #439

merged 4 commits into from
Jan 23, 2022

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented Jan 20, 2022 •
edited
Loading

  • Validated on robot

@YannLocatelli YannLocatelli self-assigned this Jan 20, 2022
@YannLocatelli YannLocatelli force-pushed the yann/feature/battery/charge-input-as-interruptin branch from f722779 to 7204585 Compare January 20, 2022 23:04
@codecov
Copy link

codecov bot commented Jan 20, 2022 •
edited
Loading

Codecov Report

Merging #439 (a64e3e8) into develop (d3c95df) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           develop      #439   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           69        69           
  Lines         1207      1213    +6     
=========================================
+ Hits          1207      1213    +6
Impacted Files Coverage Δ
drivers/CoreBattery/include/CoreBattery.h 100.00% <100.00%> (ø)
drivers/CoreBattery/source/CoreBattery.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3c95df...a64e3e8. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 82200 (3%) ø 17472 (3%) ø
bootloader ✔️ ❌ ❌ 93680 (4%)
95008 (4%)		 📈
1328 (1%)		 26200 (4%)
26792 (5%)		 📈
592 (2%)
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 251644 (11%) ø 36144 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ ✅ ✅ 183688 (8%) ø 28856 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 149336 (7%) ø 30464 (5%) ø
spike_lk_file_manager ✔️ ✅ ✅ 125884 (6%) ø 19984 (3%) ø
spike_lk_file_reception ✔️ ✅ ✅ 333692 (15%) ø 25272 (4%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 149808 (7%) ø 30088 (5%) ø
spike_lk_led ✔️ ✅ ✅ 88808 (4%) ø 19400 (3%) ø
spike_lk_log_kit ✔️ ✅ ✅ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ ✅ ✅ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ ❌ ❌ 85448 (4%)
86736 (4%)		 📈
1288 (1%)		 17512 (3%)
18056 (3%)		 📈
544 (3%)
spike_lk_sensors_light ✔️ ✅ ✅ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 92248 (4%) ø 17632 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 143764 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
bootloader (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/bootloader-map.txt	2022-01-22 16:38:51.363997018 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/bootloader-map.txt	2022-01-22 16:38:51.592005743 +0000
@@ -1,18 +1,18 @@
 | Module                 |         .text |       .data |          .bss |
 |------------------------|---------------|-------------|---------------|
-| [fill]                 |     134(+134) |       4(+4) |       24(+24) |
-| [lib]/CoreBattery.a    |     434(+434) |       0(+0) |         0(+0) |
+| [fill]                 |     162(+162) |       4(+4) |       30(+30) |
+| [lib]/CoreBattery.a    |     432(+432) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a       |   5898(+5898) |     16(+16) | 13816(+13816) |
 | [lib]/c.a              | 27020(+27020) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |   3116(+3116) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a | 47468(+47468) |   512(+512) |   8286(+8286) |
+| [lib]/mbed-os-static.a | 48530(+48530) |   512(+512) |   8824(+8824) |
 | [lib]/misc             |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |         0(+0) |       0(+0) |         0(+0) |
 | default_bd.cpp.obj     |     242(+242) |       0(+0) |     568(+568) |
-| main.cpp.obj           |     496(+496) |       0(+0) |     124(+124) |
+| main.cpp.obj           |     432(+432) |       0(+0) |     172(+172) |
 | signing_keys.c.obj     |         0(+0) |       0(+0) |         0(+0) |
-| Subtotals              | 85028(+85028) | 3008(+3008) | 22904(+22904) |
-Total Static RAM memory (data + bss): 25912(+25912) bytes
-Total Flash memory (text + data): 88036(+88036) bytes
+| Subtotals              | 86052(+86052) | 3008(+3008) | 23496(+23496) |
+Total Static RAM memory (data + bss): 26504(+26504) bytes
+Total Flash memory (text + data): 89060(+89060) bytes
 
Flash used: 95008&nbsp;(4%) / total: 2097152
SRAM used: 26792&nbsp;(5%) / total: 524288
spike_lk_sensors_battery (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_sensors_battery-map.txt	2022-01-22 16:39:01.636390133 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_sensors_battery-map.txt	2022-01-22 16:39:01.876399319 +0000
@@ -1,18 +1,17 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     122(+122) |       8(+8) |       20(+20) |
-| [lib]/CoreBattery.a     |     626(+626) |       0(+0) |         0(+0) |
+| [fill]                  |     152(+152) |       8(+8) |       26(+26) |
+| [lib]/CoreBattery.a     |     664(+664) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
-| [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
 | [lib]/c.a               | 26052(+26052) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     360(+360) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 33046(+33046) |   444(+444) |   8178(+8178) |
+| [lib]/mbed-os-static.a  | 34046(+34046) |   444(+444) |   8716(+8716) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   2504(+2504) |       0(+0) |   5960(+5960) |
-| Subtotals               | 75604(+75604) | 2936(+2936) | 14288(+14288) |
-Total Static RAM memory (data + bss): 17224(+17224) bytes
-Total Flash memory (text + data): 78540(+78540) bytes
+| main.cpp.obj            |   2554(+2554) |       0(+0) |   5960(+5960) |
+| Subtotals               | 76628(+76628) | 2936(+2936) | 14832(+14832) |
+Total Static RAM memory (data + bss): 17768(+17768) bytes
+Total Flash memory (text + data): 79564(+79564) bytes
 
Flash used: 86736&nbsp;(4%) / total: 2097152
SRAM used: 18056&nbsp;(3%) / total: 524288

@github-actions
Copy link

github-actions bot commented Jan 20, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 58328 (2%) ø 11400 (2%) ø
bootloader ✔️ ❌ ❌ 93680 (4%)
95008 (4%)		 📈
1328 (1%)		 26200 (4%)
26792 (5%)		 📈
592 (2%)
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 234668 (11%) ø 30056 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ ✅ ✅ 162616 (7%) ø 22792 (4%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 141064 (6%) ø 24464 (4%) ø
spike_lk_file_manager ✔️ ✅ ✅ 102036 (4%) ø 13672 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 328916 (15%) ø 19312 (3%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 136928 (6%) ø 24016 (4%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ ❌ ❌ 61776 (2%)
63064 (3%)		 📈
1288 (2%)		 11440 (2%)
11984 (2%)		 📈
544 (4%)
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 121348 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
bootloader (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/bootloader-map.txt	2022-01-22 16:38:51.403992429 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/bootloader-map.txt	2022-01-22 16:38:51.615996064 +0000
@@ -1,18 +1,18 @@
 | Module                 |         .text |       .data |          .bss |
 |------------------------|---------------|-------------|---------------|
-| [fill]                 |     134(+134) |       4(+4) |       24(+24) |
-| [lib]/CoreBattery.a    |     434(+434) |       0(+0) |         0(+0) |
+| [fill]                 |     162(+162) |       4(+4) |       30(+30) |
+| [lib]/CoreBattery.a    |     432(+432) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a       |   5898(+5898) |     16(+16) | 13816(+13816) |
 | [lib]/c.a              | 27020(+27020) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a            |   3116(+3116) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a | 47468(+47468) |   512(+512) |   8286(+8286) |
+| [lib]/mbed-os-static.a | 48530(+48530) |   512(+512) |   8824(+8824) |
 | [lib]/misc             |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |         0(+0) |       0(+0) |         0(+0) |
 | default_bd.cpp.obj     |     242(+242) |       0(+0) |     568(+568) |
-| main.cpp.obj           |     496(+496) |       0(+0) |     124(+124) |
+| main.cpp.obj           |     432(+432) |       0(+0) |     172(+172) |
 | signing_keys.c.obj     |         0(+0) |       0(+0) |         0(+0) |
-| Subtotals              | 85028(+85028) | 3008(+3008) | 22904(+22904) |
-Total Static RAM memory (data + bss): 25912(+25912) bytes
-Total Flash memory (text + data): 88036(+88036) bytes
+| Subtotals              | 86052(+86052) | 3008(+3008) | 23496(+23496) |
+Total Static RAM memory (data + bss): 26504(+26504) bytes
+Total Flash memory (text + data): 89060(+89060) bytes
 
Flash used: 95008&nbsp;(4%) / total: 2097152
SRAM used: 26792&nbsp;(5%) / total: 524288
spike_lk_sensors_battery (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_sensors_battery-map.txt	2022-01-22 16:39:00.360141729 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_sensors_battery-map.txt	2022-01-22 16:39:00.556144972 +0000
@@ -1,15 +1,14 @@
 | Module                 |         .text |       .data |        .bss |
 |------------------------|---------------|-------------|-------------|
-| [fill]                 |       88(+88) |       8(+8) |     16(+16) |
-| [lib]/CoreBattery.a    |     626(+626) |       0(+0) |       0(+0) |
-| [lib]/HelloWorld.a     |       94(+94) |       0(+0) |       0(+0) |
+| [fill]                 |     110(+110) |       8(+8) |     22(+22) |
+| [lib]/CoreBattery.a    |     664(+664) |       0(+0) |       0(+0) |
 | [lib]/c.a              | 25296(+25296) | 2472(+2472) |     58(+58) |
 | [lib]/gcc.a            |   3116(+3116) |       0(+0) |       0(+0) |
-| [lib]/mbed-os-static.a | 25316(+25316) |   444(+444) | 8130(+8130) |
+| [lib]/mbed-os-static.a | 26332(+26332) |   444(+444) | 8668(+8668) |
 | [lib]/misc             |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |       0(+0) |
-| main.cpp.obj           |     188(+188) |       0(+0) |       0(+0) |
-| Subtotals              | 54944(+54944) | 2928(+2928) | 8232(+8232) |
-Total Static RAM memory (data + bss): 11160(+11160) bytes
-Total Flash memory (text + data): 57872(+57872) bytes
+| main.cpp.obj           |     230(+230) |       0(+0) |       0(+0) |
+| Subtotals              | 55968(+55968) | 2928(+2928) | 8776(+8776) |
+Total Static RAM memory (data + bss): 11704(+11704) bytes
+Total Flash memory (text + data): 58896(+58896) bytes
 
Flash used: 63064&nbsp;(3%) / total: 2097152
SRAM used: 11984&nbsp;(2%) / total: 524288

@YannLocatelli YannLocatelli force-pushed the yann/feature/battery/charge-input-as-interruptin branch 3 times, most recently from 12bd71c to a4974e3 Compare January 21, 2022 11:04
@YannLocatelli YannLocatelli force-pushed the yann/feature/battery/charge-input-as-interruptin branch from a4974e3 to 90aece6 Compare January 21, 2022 15:49
ladislas
ladislas approved these changes Jan 21, 2022
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

j'ai mis une suggestion pour les callbacks

drivers/CoreBattery/include/CoreBattery.h Outdated Show resolved Hide resolved
@YannLocatelli YannLocatelli force-pushed the yann/feature/battery/charge-input-as-interruptin branch from 90aece6 to a64e3e8 Compare January 22, 2022 16:32
@sonarcloud
Copy link

sonarcloud bot commented Jan 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit e5bb325 into develop Jan 23, 2022
@ladislas ladislas deleted the yann/feature/battery/charge-input-as-interruptin branch January 23, 2022 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas approved these changes

Assignees

@YannLocatelli YannLocatelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YannLocatelli @ladislas