mmyster/feature/file system kit/error #537
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
MMyster
commented
Mar 8, 2022
MMyster
commented
- ✨ (file_system_kit): Add 'err' function
- ✨ (file_system_kit): Add 'clearerr' function
Codecov Report
@@ Coverage Diff @@
## develop #537 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 102 102
Lines 1594 1602 +8
=========================================
+ Hits 1594 1602 +8
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
MMyster
force-pushed
the
mmyster/feature/file_system_kit/error
branch
from
5db743c
to
74ef65d
Compare
ladislas
requested changes
Mar 10, 2022
libs/FileSystemKit/source/File.cpp
Outdated
| return false; | ||
| } | ||
|
|
||
| return std::ferror(_file.get()); |
There was a problem hiding this comment.
là tu as un implicite cast de int vers bool. peut être qu'il faut être explicite avec un static_cast
There was a problem hiding this comment.
En effet, je corrigerai ça
| { | ||
| auto input_data = std::to_array<uint8_t>({0x61, 0x62, 0x63, 0x64, 0x65, 0x66}); // "abcdef" | ||
|
|
||
| file.open(tempFilename, "r"); |
There was a problem hiding this comment.
le test s'appelle errorWriting et là tu read, peut être mettre dans un autre test errorReading
There was a problem hiding this comment.
En fait, je teste la fonction 'write' en mode 'r' et 'w'
|
|
||
| file.write(input_data); | ||
|
|
||
| auto error = file.err(); |
There was a problem hiding this comment.
Ouverture en mode 'read' donc écriture impossible
|
|
||
| file.write(input_data); | ||
|
|
||
| auto error = file.err(); |
|
|
||
| file.write(input_data); | ||
|
|
||
| auto error = file.err(); |
MMyster
force-pushed
the
mmyster/feature/file_system_kit/error
branch
3 times, most recently
from
655cf51
to
b98fdaa
Compare
MMyster
force-pushed
the
mmyster/feature/file_system_kit/error
branch
from
b98fdaa
to
9c5e21d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.