Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ VideoKit - Use DMA2D Interrupt mode instead of PollForTransfer mode #562

Merged
merged 3 commits into from
Mar 14, 2022
Merged

✨ VideoKit - Use DMA2D Interrupt mode instead of PollForTransfer mode #562

merged 3 commits into from
Mar 14, 2022

Conversation

YannLocatelli
Copy link
Member

No description provided.

YannLocatelli and others added 2 commits March 11, 2022 18:37
@YannLocatelli @Madour
🎨 (video): Move DMA2D HAL init into CoreDMA2D
4005d7a 
RCC + NVIC

Co-Authored-By: Modar Nasser <11854124+Madour@users.noreply.github.com>
@YannLocatelli @Madour
🐛 Fix display of an image with width different of lcd width
be99f4d 
🐛 (dma2d) fix DMA2D output offset

Co-Authored-By: Modar Nasser <11854124+Madour@users.noreply.github.com>
@YannLocatelli YannLocatelli self-assigned this Mar 13, 2022
@codecov
Copy link

codecov bot commented Mar 13, 2022 •
edited
Loading

Codecov Report

Merging #562 (97bdbad) into develop (da44c6c) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##           develop      #562   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          105       106    +1     
  Lines         1629      1631    +2     
=========================================
+ Hits          1629      1631    +2
Impacted Files Coverage Δ
drivers/CoreVideo/include/interface/DMA2D.hpp 100.00% <ø> (ø)
drivers/CoreVideo/source/CoreVideo.cpp 100.00% <ø> (ø)
include/interface/drivers/STM32Hal.h 100.00% <ø> (ø)
drivers/CoreVideo/include/CoreDMA2D.hpp 100.00% <100.00%> (ø)
drivers/CoreVideo/source/CoreDMA2D.cpp 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link

github-actions bot commented Mar 13, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 138964 (53%) 123180 (46%) 29360 (5%)
os 212080 (13%) 1352592 (86%) 24712 (4%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 212080 (10%) ø 24712 (4%) ø
bootloader ✔️ ✅ ✅ 138964 (6%) ø 29360 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 250624 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ ✅ ✅ 173940 (8%) ø 23904 (4%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ❌ ❌ 141112 (6%)
141176 (6%)		 📈
64 (0%)		 24464 (4%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65584 (3%) ø 13624 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 326904 (15%) ø 27576 (5%) ø
spike_lk_filesystem_kit ✔️ ✅ ✅ 103476 (4%) ø 14048 (2%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ❌ ❌ 136976 (6%)
137360 (6%)		 📈
384 (0%)		 24024 (4%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ ✅ ✅ 100428 (4%) ø 14640 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62528 (2%) ø 11488 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 122724 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_cg_animations (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_cg_animations-map.txt	2022-03-13 13:38:57.971359065 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_cg_animations-map.txt	2022-03-13 13:38:58.167360939 +0000
@@ -1,19 +1,19 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
-| [fill]                 |       156(+156) |       7(+7) |       34(+34) |
+| [fill]                 |       160(+160) |       7(+7) |       34(+34) |
 | [lib]/CoreFs.a         |         40(+40) |       0(+0) |         0(+0) |
-| [lib]/CoreSTM32Hal.a   |       804(+804) |       0(+0) |         0(+0) |
-| [lib]/CoreVideo.a      |     6510(+6510) |       1(+1) |   4160(+4160) |
+| [lib]/CoreSTM32Hal.a   |       826(+826) |       0(+0) |         0(+0) |
+| [lib]/CoreVideo.a      |     6488(+6488) |       1(+1) |   4160(+4160) |
 | [lib]/HelloWorld.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/UIAnimationKit.a |       540(+540) |       0(+0) |         0(+0) |
 | [lib]/c.a              |   36984(+36984) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a            |     7148(+7148) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a |   60432(+60432) |   460(+460) | 10269(+10269) |
+| [lib]/mbed-os-static.a |   60492(+60492) |   460(+460) | 10269(+10269) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |     5356(+5356) |       8(+8) |       44(+44) |
 | main.cpp.obj           |       980(+980) |     52(+52) |   6440(+6440) |
-| Subtotals              | 119264(+119264) | 3104(+3104) | 21072(+21072) |
+| Subtotals              | 119328(+119328) | 3104(+3104) | 21072(+21072) |
 Total Static RAM memory (data + bss): 24176(+24176) bytes
-Total Flash memory (text + data): 122368(+122368) bytes
+Total Flash memory (text + data): 122432(+122432) bytes
 
Flash used: 141176&nbsp;(6%) / total: 2097152
SRAM used: 24464&nbsp;(4%) / total: 524288
spike_lk_lcd (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_lcd-map.txt	2022-03-13 13:39:00.843386516 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_lcd-map.txt	2022-03-13 13:39:01.035388351 +0000
@@ -1,18 +1,18 @@
 | Module                 |           .text |       .data |          .bss |
 |------------------------|-----------------|-------------|---------------|
-| [fill]                 |       164(+164) |       7(+7) |       34(+34) |
+| [fill]                 |       188(+188) |       7(+7) |       34(+34) |
 | [lib]/CoreFs.a         |         40(+40) |       0(+0) |         0(+0) |
-| [lib]/CoreSTM32Hal.a   |       804(+804) |       0(+0) |         0(+0) |
-| [lib]/CoreVideo.a      |     6556(+6556) |       1(+1) |   4160(+4160) |
+| [lib]/CoreSTM32Hal.a   |       826(+826) |       0(+0) |         0(+0) |
+| [lib]/CoreVideo.a      |     6534(+6534) |       1(+1) |   4160(+4160) |
 | [lib]/HelloWorld.a     |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/c.a              |   36984(+36984) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a            |     7148(+7148) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a |   56654(+56654) |   460(+460) | 10269(+10269) |
+| [lib]/mbed-os-static.a |   56994(+56994) |   460(+460) | 10269(+10269) |
 | [lib]/misc             |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a          |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a         |     5356(+5356) |       8(+8) |       44(+44) |
-| main.cpp.obj           |     1148(+1148) |     52(+52) |   6000(+6000) |
-| Subtotals              | 115168(+115168) | 3104(+3104) | 20632(+20632) |
+| main.cpp.obj           |     1168(+1168) |     52(+52) |   6000(+6000) |
+| Subtotals              | 115552(+115552) | 3104(+3104) | 20632(+20632) |
 Total Static RAM memory (data + bss): 23736(+23736) bytes
-Total Flash memory (text + data): 118272(+118272) bytes
+Total Flash memory (text + data): 118656(+118656) bytes
 
Flash used: 137360&nbsp;(6%) / total: 2097152
SRAM used: 24024&nbsp;(4%) / total: 524288

@github-actions
Copy link

github-actions bot commented Mar 13, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 138964 (53%) 123180 (46%) 29360 (5%)
os 221508 (14%) 1343164 (85%) 30720 (5%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 221508 (10%) ø 30720 (5%) ø
bootloader ✔️ ✅ ✅ 138964 (6%) ø 29360 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 258168 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ ✅ ✅ 183224 (8%) ø 29856 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ ❌ ❌ 149384 (7%)
149448 (7%)		 📈
64 (0%)		 30464 (5%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88800 (4%) ø 19624 (3%) ø
spike_lk_coreled ✔️ ✅ ✅ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331612 (15%) ø 33536 (6%) ø
spike_lk_filesystem_kit ✔️ ✅ ✅ 127580 (6%) ø 20216 (3%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ ❌ ❌ 149792 (7%)
150176 (7%)		 📈
384 (0%)		 30096 (5%) ø
spike_lk_led ✔️ ✅ ✅ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ ✅ ✅ 109636 (5%) ø 20648 (3%) ø
spike_lk_log_kit ✔️ ✅ ✅ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86576 (4%) ø 17552 (3%) ø
spike_lk_rfid ✔️ ✅ ✅ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87600 (4%) ø 18584 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 92248 (4%) ø 17632 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 145204 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_cg_animations (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_cg_animations-map.txt	2022-03-13 13:39:34.492531103 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_cg_animations-map.txt	2022-03-13 13:39:34.736534063 +0000
@@ -1,21 +1,21 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       216(+216) |       7(+7) |       38(+38) |
+| [fill]                  |       220(+220) |       7(+7) |       38(+38) |
 | [lib]/CoreFs.a          |         40(+40) |       0(+0) |         0(+0) |
-| [lib]/CoreSTM32Hal.a    |       804(+804) |       0(+0) |         0(+0) |
-| [lib]/CoreVideo.a       |     6510(+6510) |       1(+1) |   4160(+4160) |
+| [lib]/CoreSTM32Hal.a    |       826(+826) |       0(+0) |         0(+0) |
+| [lib]/CoreVideo.a       |     6488(+6488) |       1(+1) |   4160(+4160) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/UIAnimationKit.a  |       508(+508) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   37008(+37008) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  |   63972(+63972) |   460(+460) | 10305(+10305) |
+| [lib]/mbed-os-static.a  |   64032(+64032) |   460(+460) | 10305(+10305) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5864(+5864) |       8(+8) |       44(+44) |
 | main.cpp.obj            |     3184(+3184) |     52(+52) | 12400(+12400) |
-| Subtotals               | 125936(+125936) | 3104(+3104) | 27072(+27072) |
+| Subtotals               | 126000(+126000) | 3104(+3104) | 27072(+27072) |
 Total Static RAM memory (data + bss): 30176(+30176) bytes
-Total Flash memory (text + data): 129040(+129040) bytes
+Total Flash memory (text + data): 129104(+129104) bytes
 
Flash used: 149448&nbsp;(7%) / total: 2097152
SRAM used: 30464&nbsp;(5%) / total: 524288
spike_lk_lcd (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_lcd-map.txt	2022-03-13 13:39:38.100574876 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_lcd-map.txt	2022-03-13 13:39:38.332577690 +0000
@@ -1,20 +1,20 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       180(+180) |       7(+7) |       38(+38) |
+| [fill]                  |       204(+204) |       7(+7) |       38(+38) |
 | [lib]/CoreFs.a          |         40(+40) |       0(+0) |         0(+0) |
-| [lib]/CoreSTM32Hal.a    |       804(+804) |       0(+0) |         0(+0) |
-| [lib]/CoreVideo.a       |     6572(+6572) |       1(+1) |   4160(+4160) |
+| [lib]/CoreSTM32Hal.a    |       826(+826) |       0(+0) |         0(+0) |
+| [lib]/CoreVideo.a       |     6550(+6550) |       1(+1) |   4160(+4160) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   37008(+37008) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  |   63994(+63994) |   460(+460) | 10305(+10305) |
+| [lib]/mbed-os-static.a  |   64334(+64334) |   460(+460) | 10305(+10305) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5864(+5864) |       8(+8) |       44(+44) |
-| main.cpp.obj            |     3900(+3900) |     60(+60) | 12024(+12024) |
-| Subtotals               | 126192(+126192) | 3112(+3112) | 26696(+26696) |
+| main.cpp.obj            |     3920(+3920) |     60(+60) | 12024(+12024) |
+| Subtotals               | 126576(+126576) | 3112(+3112) | 26696(+26696) |
 Total Static RAM memory (data + bss): 29808(+29808) bytes
-Total Flash memory (text + data): 129304(+129304) bytes
+Total Flash memory (text + data): 129688(+129688) bytes
 
Flash used: 150176&nbsp;(7%) / total: 2097152
SRAM used: 30096&nbsp;(5%) / total: 524288

@YannLocatelli @Madour
⚡ (video): Use DMA2D Interrupt instead of PollForTransfer
97bdbad 
Co-Authored-By: Modar Nasser <11854124+Madour@users.noreply.github.com>
@YannLocatelli YannLocatelli force-pushed the yann/feature/videokit/update-dma2d branch from be708a5 to 97bdbad Compare March 13, 2022 13:32
@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

95.0% 95.0% Coverage
0.0% 0.0% Duplication

ladislas
ladislas approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@ladislas ladislas merged commit f95f950 into develop Mar 14, 2022
@YannLocatelli YannLocatelli deleted the yann/feature/videokit/update-dma2d branch March 14, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas approved these changes

Assignees

@YannLocatelli YannLocatelli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YannLocatelli @ladislas