🚸 (video): Set screen in correct orientation #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
YannLocatelli
force-pushed
the
yann/feature/videokit/set-screen-orientation
branch
from
9d1db1d
to
afc8565
Compare
Codecov Report
@@ Coverage Diff @@
## develop #568 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 106 106
Lines 1636 1631 -5
=========================================
- Hits 1636 1631 -5
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
ladislas
approved these changes
Mar 14, 2022
Comment on lines
+49
to
+52
| auto set_landscape_mode = [&] { _settings |= (1 << 5); }; | ||
| auto set_horizontal_symmetry = [&] { _settings |= (1 << 6); }; | ||
| set_landscape_mode(); | ||
| set_horizontal_symmetry(); |
There was a problem hiding this comment.
si tu veux éviter d'appeler les lambda, tu peux faire ça pour appeler direct:
Suggested change
| auto set_landscape_mode = [&] { _settings |= (1 << 5); }; | |
| auto set_horizontal_symmetry = [&] { _settings |= (1 << 6); }; | |
| set_landscape_mode(); | |
| set_horizontal_symmetry(); | |
| auto set_landscape_mode = [&] { _settings |= (1 << 5); }(); | |
| auto set_horizontal_symmetry = [&] { _settings |= (1 << 6); }(); |
There was a problem hiding this comment.
Mh, ça génère une erreur comme quoi la variable est de type void
ladislas
force-pushed
the
yann/feature/videokit/set-screen-orientation
branch
from
afc8565
to
b07dabd
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.