✨ (os): Implement ApplyUpdate + registerOnUpdateLoaded #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #586 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 107 107
Lines 1698 1704 +6
=========================================
+ Hits 1698 1704 +6
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
ladislas
approved these changes
Mar 15, 2022
app/os/main.cpp
Outdated
Comment on lines
35
to
37
| auto coremanageris25lp = CoreFlashManagerIS25LP016D(coreqspi); | ||
| auto coreis25lp = CoreFlashIS25LP016D(coreqspi, coremanageris25lp); | ||
| auto firmwarekit = FirmwareKit(coreis25lp); |
There was a problem hiding this comment.
Suggested change
| auto coremanageris25lp = CoreFlashManagerIS25LP016D(coreqspi); | |
| auto coreis25lp = CoreFlashIS25LP016D(coreqspi, coremanageris25lp); | |
| auto firmwarekit = FirmwareKit(coreis25lp); | |
| auto coreflashmanager = CoreFlashManagerIS25LP016D(coreqspi); | |
| auto coreflash = CoreFlashIS25LP016D(coreqspi, coremanageris25lp); | |
| auto firmwarekit = FirmwareKit(coreflash); |
mais ça fait bizarre d'avoir le manager de la flash qui est passé en argument pour la flash, j'aurais fait l'inverse.
There was a problem hiding this comment.
Il faudrait revoir nos discussions pour voir ce qui avait motivé à implémenter le Manager dans la Memory et non l'inverse
There was a problem hiding this comment.
je fais un task, c'est pas urgent et si ça se trouve c'est juste une problème de naming. ;)
YannLocatelli
force-pushed
the
yann/feature/os/perform-update
branch
2 times, most recently
from
2767983
to
58205e7
Compare
ladislas
force-pushed
the
yann/feature/os/perform-update
branch
from
58205e7
to
e818055
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.