Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ (s/n): Add SerialNumberKit #605

Merged
merged 3 commits into from
Mar 18, 2022

Conversation

YannLocatelli
Copy link
Member

No description provided.

@YannLocatelli YannLocatelli self-assigned this Mar 17, 2022
@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #605 (5282ef5) into develop (508ff57) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 5282ef5 differs from pull request most recent head 64693a4. Consider uploading reports for the commit 64693a4 to get more accurate results

@@            Coverage Diff            @@
##           develop      #605   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           85        87    +2     
  Lines         1692      1701    +9     
=========================================
+ Hits          1692      1701    +9     
Impacted Files Coverage Δ
libs/SerialNumberKit/include/SerialNumberKit.h 100.00% <100.00%> (ø)
libs/SerialNumberKit/source/SerialNumberKit.cpp 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@YannLocatelli YannLocatelli force-pushed the yann/feature/serial-number/create-SerialNumberKit branch from 44765d3 to e574b39 Compare March 18, 2022 00:03
@github-actions
Copy link

github-actions bot commented Mar 18, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 140204 (53%) 121940 (46%) 29512 (5%)
os 238688 (15%) 1325984 (84%) 26632 (5%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 238752 (11%)
238688 (11%)
📉
-64 (0%)
26640 (5%)
26632 (5%)
📉
-8 (0%)
bootloader ✔️ 140204 (6%) ø 29512 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 250624 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 177960 (8%) ø 24360 (4%) ø
spike_lk_ble ✔️ 174572 (8%) ø 24456 (4%) ø
spike_lk_bluetooth ✔️ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ 141016 (6%) ø 24416 (4%) ø
spike_lk_color_kit ✔️ 65584 (3%) ø 13624 (2%) ø
spike_lk_coreled ✔️ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_reception ✔️ 326904 (15%) ø 27576 (5%) ø
spike_lk_filesystem_kit ✔️ 103540 (4%) ø 14048 (2%) ø
spike_lk_flash_memory ✔️ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ 142584 (6%) ø 23992 (4%) ø
spike_lk_led ✔️ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ 101516 (4%) ø 14640 (2%) ø
spike_lk_log_kit ✔️ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ 62528 (2%) ø 11488 (2%) ø
spike_lk_reinforcer ✔️ 72968 (3%) ø 14240 (2%) ø
spike_lk_rfid ✔️ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ 58560 (2%)
58904 (2%)
📈
344 (0%)
11424 (2%)
11464 (2%)
📈
40 (0%)
spike_lk_ticker_timeout ✔️ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ 122724 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-03-18 14:36:42.080929413 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-03-18 14:36:42.384934880 +0000
@@ -1,25 +1,25 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       412(+412) |     13(+13) |       91(+91) |
+| [fill]                  |       440(+440) |     13(+13) |       91(+91) |
 | [lib]/BLEKit.a          |     1154(+1154) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       296(+296) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       154(+154) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a   |       738(+738) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   42336(+42336) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7084(+7084) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 154946(+154946) |   769(+769) | 19519(+19519) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     4116(+4116) |       8(+8) |       28(+28) |
-| main.cpp.obj            |     4774(+4774) |     70(+70) |   3001(+3001) |
-| Subtotals               | 219160(+219160) | 3448(+3448) | 22896(+22896) |
-Total Static RAM memory (data + bss): 26344(+26344) bytes
-Total Flash memory (text + data): 222608(+222608) bytes
+| main.cpp.obj            |     4682(+4682) |     70(+70) |   2993(+2993) |
+| Subtotals               | 219096(+219096) | 3448(+3448) | 22888(+22888) |
+Total Static RAM memory (data + bss): 26336(+26336) bytes
+Total Flash memory (text + data): 222544(+222544) bytes
 
Flash used: 238688&nbsp;(11%) / total: 2097152
SRAM used: 26632&nbsp;(5%) / total: 524288
spike_lk_serial_number (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_serial_number-map.txt	2022-03-18 14:36:54.801160744 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_serial_number-map.txt	2022-03-18 14:36:54.977163970 +0000
@@ -1,15 +1,16 @@
-| Module                 |         .text |       .data |        .bss |
-|------------------------|---------------|-------------|-------------|
-| [fill]                 |       84(+84) |       8(+8) |     16(+16) |
-| [lib]/CoreMCU.a        |       16(+16) |       0(+0) |       0(+0) |
-| [lib]/HelloWorld.a     |       94(+94) |       0(+0) |       0(+0) |
-| [lib]/c.a              | 25296(+25296) | 2472(+2472) |     58(+58) |
-| [lib]/gcc.a            |   3116(+3116) |       0(+0) |       0(+0) |
-| [lib]/mbed-os-static.a | 23342(+23342) |   444(+444) | 8098(+8098) |
-| [lib]/misc             |     188(+188) |       4(+4) |     28(+28) |
-| [lib]/nosys.a          |       32(+32) |       0(+0) |       0(+0) |
-| main.cpp.obj           |     216(+216) |       8(+8) |       0(+0) |
-| Subtotals              | 52384(+52384) | 2936(+2936) | 8200(+8200) |
-Total Static RAM memory (data + bss): 11136(+11136) bytes
-Total Flash memory (text + data): 55320(+55320) bytes
+| Module                  |         .text |       .data |        .bss |
+|-------------------------|---------------|-------------|-------------|
+| [fill]                  |       72(+72) |       8(+8) |     16(+16) |
+| [lib]/CoreMCU.a         |       16(+16) |       0(+0) |       0(+0) |
+| [lib]/HelloWorld.a      |       94(+94) |       0(+0) |       0(+0) |
+| [lib]/SerialNumberKit.a |     160(+160) |       0(+0) |       0(+0) |
+| [lib]/c.a               | 25432(+25432) | 2472(+2472) |     58(+58) |
+| [lib]/gcc.a             |   3116(+3116) |       0(+0) |       0(+0) |
+| [lib]/mbed-os-static.a  | 23342(+23342) |   444(+444) | 8098(+8098) |
+| [lib]/misc              |     188(+188) |       4(+4) |     28(+28) |
+| [lib]/nosys.a           |       32(+32) |       0(+0) |       0(+0) |
+| main.cpp.obj            |     252(+252) |       8(+8) |     40(+40) |
+| Subtotals               | 52704(+52704) | 2936(+2936) | 8240(+8240) |
+Total Static RAM memory (data + bss): 11176(+11176) bytes
+Total Flash memory (text + data): 55640(+55640) bytes
 
Flash used: 58904&nbsp;(2%) / total: 2097152
SRAM used: 11464&nbsp;(2%) / total: 524288

@github-actions
Copy link

github-actions bot commented Mar 18, 2022

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 140204 (53%) 121940 (46%) 29512 (5%)
os 247988 (15%) 1316684 (84%) 32640 (6%)
Click to show memory sections
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ 248052 (11%)
247988 (11%)
📉
-64 (0%)
32648 (6%)
32640 (6%)
📉
-8 (0%)
bootloader ✔️ 140204 (6%) ø 29512 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ 258168 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ 194032 (9%) ø 30384 (5%) ø
spike_lk_ble ✔️ 184256 (8%) ø 30536 (5%) ø
spike_lk_bluetooth ✔️ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ 149224 (7%) ø 30416 (5%) ø
spike_lk_color_kit ✔️ 88800 (4%) ø 19624 (3%) ø
spike_lk_coreled ✔️ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_reception ✔️ 331612 (15%) ø 33536 (6%) ø
spike_lk_filesystem_kit ✔️ 127740 (6%) ø 20216 (3%) ø
spike_lk_flash_memory ✔️ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ 155544 (7%) ø 30064 (5%) ø
spike_lk_led ✔️ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ 109516 (5%) ø 20576 (3%) ø
spike_lk_log_kit ✔️ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ 86576 (4%) ø 17552 (3%) ø
spike_lk_reinforcer ✔️ 91808 (4%) ø 20232 (3%) ø
spike_lk_rfid ✔️ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ 87600 (4%) ø 18584 (3%) ø
spike_lk_sensors_light ✔️ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ 92248 (4%) ø 17632 (3%) ø
spike_lk_serial_number ✔️ 82400 (3%)
82752 (3%)
📈
352 (0%)
17544 (3%)
17648 (3%)
📈
104 (0%)
spike_lk_ticker_timeout ✔️ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ 145204 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-03-18 14:38:20.636463087 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-03-18 14:38:20.976473278 +0000
@@ -1,27 +1,27 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       430(+430) |     13(+13) |       87(+87) |
+| [fill]                  |       458(+458) |     13(+13) |       87(+87) |
 | [lib]/BLEKit.a          |     1154(+1154) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       260(+260) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       122(+122) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a   |       738(+738) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   42224(+42224) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 158470(+158470) |   769(+769) | 19555(+19555) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |     7112(+7112) |     70(+70) |   8961(+8961) |
-| Subtotals               | 226600(+226600) | 3448(+3448) | 28904(+28904) |
-Total Static RAM memory (data + bss): 32352(+32352) bytes
-Total Flash memory (text + data): 230048(+230048) bytes
+| main.cpp.obj            |     7020(+7020) |     70(+70) |   8953(+8953) |
+| Subtotals               | 226536(+226536) | 3448(+3448) | 28896(+28896) |
+Total Static RAM memory (data + bss): 32344(+32344) bytes
+Total Flash memory (text + data): 229984(+229984) bytes
 
Flash used: 247988&nbsp;(11%) / total: 2097152
SRAM used: 32640&nbsp;(6%) / total: 524288
spike_lk_serial_number (click to expand)
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_serial_number-map.txt	2022-03-18 14:38:35.944931356 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_serial_number-map.txt	2022-03-18 14:38:36.156937921 +0000
@@ -1,18 +1,19 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
 | [fill]                  |     144(+144) |       8(+8) |       20(+20) |
 | [lib]/CoreMCU.a         |       16(+16) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
+| [lib]/SerialNumberKit.a |     160(+160) |       0(+0) |         0(+0) |
 | [lib]/c.a               | 26052(+26052) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 31130(+31130) |   444(+444) |   8138(+8138) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   2576(+2576) |       8(+8) |   6024(+6024) |
-| Subtotals               | 73172(+73172) | 2944(+2944) | 14312(+14312) |
-Total Static RAM memory (data + bss): 17256(+17256) bytes
-Total Flash memory (text + data): 76116(+76116) bytes
+| main.cpp.obj            |   2736(+2736) |       8(+8) |   6128(+6128) |
+| Subtotals               | 73492(+73492) | 2944(+2944) | 14416(+14416) |
+Total Static RAM memory (data + bss): 17360(+17360) bytes
+Total Flash memory (text + data): 76436(+76436) bytes
 
Flash used: 82752&nbsp;(3%) / total: 2097152
SRAM used: 17648&nbsp;(3%) / total: 524288

@YannLocatelli YannLocatelli force-pushed the yann/feature/serial-number/create-SerialNumberKit branch from e574b39 to 5282ef5 Compare March 18, 2022 14:30
@ladislas ladislas force-pushed the yann/feature/serial-number/create-SerialNumberKit branch from 5282ef5 to 64693a4 Compare March 18, 2022 15:00
@ladislas ladislas merged commit 3db68ed into develop Mar 18, 2022
@ladislas ladislas deleted the yann/feature/serial-number/create-SerialNumberKit branch March 18, 2022 15:01
@sonarcloud
Copy link

sonarcloud bot commented Mar 18, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants