✨ (rc): Set SerialNumber in BLE #611

YannLocatelli · 2022-03-18T21:45:48Z

No description provided.

codecov · 2022-03-18T21:51:56Z

Codecov Report

Merging #611 (a891407) into develop (ecd5579) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a891407 differs from pull request most recent head 823c6c7. Consider uploading reports for the commit 823c6c7 to get more accurate results

@@           Coverage Diff            @@
##           develop     #611   +/-   ##
========================================
  Coverage    97.61%   97.61%           
========================================
  Files           89       89           
  Lines         1801     1803    +2     
========================================
+ Hits          1758     1760    +2     
  Misses          43       43

Impacted Files	Coverage Δ
libs/RobotKit/include/RobotController.h	`100.00% <100.00%> (ø)`

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

github-actions · 2022-03-18T22:01:39Z

File comparision analysis report

🔖 Info

base: develop / e68ff2e + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/rc/transfer-serial-number-via-ble / 823c6c7 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	140204 (53%)	121940 (46%)	29512 (5%)
os	255760 (16%)	1308912 (83%)	28536 (5%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	255384 (12%) 255760 (12%)	📈 376 (0%)	28480 (5%) 28536 (5%)	📈 56 (0%)
bootloader	✔️	✅	✅	140204 (6%)	ø	29512 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	250624 (11%)	ø	29240 (5%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	174568 (8%)	ø	24952 (4%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	148840 (7%)	ø	22528 (4%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	177960 (8%)	ø	24360 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	117268 (5%)	ø	15432 (2%)	ø
spike_lk_ble	✔️	✅	✅	174572 (8%)	ø	24456 (4%)	ø
spike_lk_bluetooth	✔️	✅	✅	73256 (3%)	ø	11448 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	141016 (6%)	ø	24416 (4%)	ø
spike_lk_color_kit	✔️	✅	✅	65584 (3%)	ø	13624 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	326904 (15%)	ø	27576 (5%)	ø
spike_lk_filesystem_kit	✔️	✅	✅	103540 (4%)	ø	14048 (2%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_lcd	✔️	✅	✅	142584 (6%)	ø	23992 (4%)	ø
spike_lk_led	✔️	✅	✅	65744 (3%)	ø	13392 (2%)	ø
spike_lk_led_kit	✔️	✅	✅	77336 (3%)	ø	14376 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	68528 (3%)	ø	11912 (2%)	ø
spike_lk_motors	✔️	✅	✅	62528 (2%)	ø	11488 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	77336 (3%)	ø	14376 (2%)	ø
spike_lk_rfid	✔️	✅	✅	73072 (3%)	ø	11448 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	66968 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	58904 (2%)	ø	11464 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	122724 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-03-20 08:19:01.462729776 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-03-20 08:19:01.806756265 +0000
@@ -1,32 +1,34 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       488(+488) |     13(+13) |       94(+94) |
+| [fill]                  |       444(+444) |     13(+13) |       94(+94) |
 | [lib]/BLEKit.a          |     1154(+1154) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       372(+372) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a     |       498(+498) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a        |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
+| [lib]/CoreMCU.a         |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a   |       738(+738) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a          |     5516(+5516) |       0(+0) |         0(+0) |
+| [lib]/SerialNumberKit.a |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   42396(+42396) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 157884(+157884) |   769(+769) | 19611(+19611) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     4116(+4116) |       8(+8) |       28(+28) |
-| main.cpp.obj            |     9066(+9066) |   246(+246) |   4562(+4562) |
-| Subtotals               | 233880(+233880) | 3624(+3624) | 24552(+24552) |
-Total Static RAM memory (data + bss): 28176(+28176) bytes
-Total Flash memory (text + data): 237504(+237504) bytes
+| main.cpp.obj            |     9254(+9254) |   254(+254) |   4610(+4610) |
+| Subtotals               | 234200(+234200) | 3632(+3632) | 24600(+24600) |
+Total Static RAM memory (data + bss): 28232(+28232) bytes
+Total Flash memory (text + data): 237832(+237832) bytes

Flash used: 255760&nbsp;(12%) / total: 2097152
SRAM used: 28536&nbsp;(5%) / total: 524288

github-actions · 2022-03-18T22:02:09Z

File comparision analysis report

🔖 Info

base: develop / e68ff2e + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/rc/transfer-serial-number-via-ble / 823c6c7 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	140204 (53%)	121940 (46%)	29512 (5%)
os	265060 (16%)	1299612 (83%)	34552 (6%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	❌	❌	264620 (12%) 265060 (12%)	📈 440 (0%)	34496 (6%) 34552 (6%)	📈 56 (0%)
bootloader	✔️	✅	✅	140204 (6%)	ø	29512 (5%)	ø
certs_emc_ble_bt_lcd_led_motors	✔️	✅	✅	258168 (12%)	ø	35272 (6%)	ø
certs_emc_ble_led_motors	✔️	✅	✅	191600 (9%)	ø	30976 (5%)	ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi	✔️	✅	✅	165248 (7%)	ø	28680 (5%)	ø
certs_emc_lcd_led_motors	✔️	✅	✅	91928 (4%)	ø	16168 (3%)	ø
hardware_motors_test_reduction_and_wheels	✔️	✅	✅	194032 (9%)	ø	30384 (5%)	ø
spike_lk_behavior_kit	✔️	✅	✅	135332 (6%)	ø	21416 (4%)	ø
spike_lk_ble	✔️	✅	✅	184256 (8%)	ø	30536 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	91192 (4%)	ø	17472 (3%)	ø
spike_lk_cg_animations	✔️	✅	✅	149224 (7%)	ø	30416 (5%)	ø
spike_lk_color_kit	✔️	✅	✅	88800 (4%)	ø	19624 (3%)	ø
spike_lk_coreled	✔️	✅	✅	88556 (4%)	ø	19632 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84664 (4%)	ø	18136 (3%)	ø
spike_lk_file_reception	✔️	✅	✅	331612 (15%)	ø	33536 (6%)	ø
spike_lk_filesystem_kit	✔️	✅	✅	127740 (6%)	ø	20216 (3%)	ø
spike_lk_flash_memory	✔️	✅	✅	87352 (4%)	ø	17512 (3%)	ø
spike_lk_lcd	✔️	✅	✅	155544 (7%)	ø	30064 (5%)	ø
spike_lk_led	✔️	✅	✅	88808 (4%)	ø	19400 (3%)	ø
spike_lk_led_kit	✔️	✅	✅	96184 (4%)	ø	20376 (3%)	ø
spike_lk_log_kit	✔️	✅	✅	92000 (4%)	ø	18168 (3%)	ø
spike_lk_motors	✔️	✅	✅	86576 (4%)	ø	17552 (3%)	ø
spike_lk_reinforcer	✔️	✅	✅	96184 (4%)	ø	20376 (3%)	ø
spike_lk_rfid	✔️	✅	✅	91008 (4%)	ø	17472 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87600 (4%)	ø	18584 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	84584 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	85336 (4%)	ø	17512 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90896 (4%)	ø	17496 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	92248 (4%)	ø	17632 (3%)	ø
spike_lk_serial_number	✔️	✅	✅	82752 (3%)	ø	17648 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	83224 (3%)	ø	17592 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	145204 (6%)	ø	21352 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100968 (4%)	ø	18472 (3%)	ø
spike_lk_wifi	✔️	✅	✅	131280 (6%)	ø	20832 (3%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84688 (4%)	ø	18448 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	84000 (4%)	ø	17536 (3%)	ø

🗺️ Map files diff output

Click to show diff list

LekaOS (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-03-20 08:18:53.175985720 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-03-20 08:18:53.503987562 +0000
@@ -1,33 +1,35 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       494(+494) |     13(+13) |       98(+98) |
+| [fill]                  |       518(+518) |     13(+13) |       98(+98) |
 | [lib]/BLEKit.a          |     1154(+1154) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       336(+336) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a     |       498(+498) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a        |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
+| [lib]/CoreMCU.a         |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileSystemKit.a   |       738(+738) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a          |     5516(+5516) |       0(+0) |         0(+0) |
+| [lib]/SerialNumberKit.a |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   42284(+42284) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       564(+564) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 161408(+161408) |   769(+769) | 19647(+19647) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   11384(+11384) |   246(+246) | 10522(+10522) |
-| Subtotals               | 241256(+241256) | 3624(+3624) | 30568(+30568) |
-Total Static RAM memory (data + bss): 34192(+34192) bytes
-Total Flash memory (text + data): 244880(+244880) bytes
+| main.cpp.obj            |   11568(+11568) |   254(+254) | 10570(+10570) |
+| Subtotals               | 241640(+241640) | 3632(+3632) | 30616(+30616) |
+Total Static RAM memory (data + bss): 34248(+34248) bytes
+Total Flash memory (text + data): 245272(+245272) bytes

Flash used: 265060&nbsp;(12%) / total: 2097152
SRAM used: 34552&nbsp;(6%) / total: 524288

sonarcloud · 2022-03-20T08:19:47Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

100.0% Coverage
0.0% Duplication

YannLocatelli self-assigned this Mar 18, 2022

YannLocatelli force-pushed the yann/feature/rc/transfer-serial-number-via-ble branch from 1a87cfb to 5911c1f Compare March 18, 2022 21:48

YannLocatelli requested a review from ladislas March 19, 2022 13:13

ladislas approved these changes Mar 19, 2022

View reviewed changes

YannLocatelli added 2 commits March 20, 2022 01:41

🚸 (rc): Display Launching Behavior for 3s

9910a0a

🚸 (rc): Increase sleep timeout duration from 10s to 300s

0824518

YannLocatelli force-pushed the yann/feature/rc/transfer-serial-number-via-ble branch from 5911c1f to a891407 Compare March 20, 2022 00:45

ladislas and others added 2 commits March 20, 2022 09:10

🔀 Merge branch 'yann/fix/os/duration-setup-sleep-timeout' into develop

93ec8c0

✨ (rc): Set SerialNumber in BLE

823c6c7

ladislas force-pushed the yann/feature/rc/transfer-serial-number-via-ble branch from a891407 to 823c6c7 Compare March 20, 2022 08:11

ladislas merged commit e68ff2e into develop Mar 20, 2022

ladislas deleted the yann/feature/rc/transfer-serial-number-via-ble branch March 20, 2022 13:40

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ (rc): Set SerialNumber in BLE #611

✨ (rc): Set SerialNumber in BLE #611

YannLocatelli commented Mar 18, 2022

codecov bot commented Mar 18, 2022 •

edited

Loading

github-actions bot commented Mar 18, 2022 •

edited

Loading

github-actions bot commented Mar 18, 2022 •

edited

Loading

sonarcloud bot commented Mar 20, 2022

✨ (rc): Set SerialNumber in BLE #611

✨ (rc): Set SerialNumber in BLE #611

Conversation

YannLocatelli commented Mar 18, 2022

codecov bot commented Mar 18, 2022 • edited Loading

Codecov Report

github-actions bot commented Mar 18, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Mar 18, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

sonarcloud bot commented Mar 20, 2022

codecov bot commented Mar 18, 2022 •

edited

Loading

github-actions bot commented Mar 18, 2022 •

edited

Loading

github-actions bot commented Mar 18, 2022 •

edited

Loading