Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⚡️ (ble): Set dynamic data in advertising (name, battery level, battery is charging) #633

Merged
merged 3 commits into from
Apr 20, 2022
Merged

⚡️ (ble): Set dynamic data in advertising (name, battery level, battery is charging) #633

merged 3 commits into from
Apr 20, 2022

Conversation

YannLocatelli
Copy link
Member

No description provided.

@YannLocatelli YannLocatelli self-assigned this Mar 25, 2022
@YannLocatelli YannLocatelli mentioned this pull request Apr 5, 2022
Closed
@YannLocatelli YannLocatelli added this to the v1.0.0 milestone Apr 5, 2022
@ladislas ladislas added the 01 - type: task Something to do label Apr 8, 2022
@YannLocatelli YannLocatelli force-pushed the yann/feature/ble/set-battery-level-in-advertising-data branch from 44ca092 to 52896a4 Compare April 8, 2022 19:54
@YannLocatelli YannLocatelli changed the title ⚡️ (ble): Set dynamic battery level in advertising data ⚡️ (ble): Set dynamic data in advertising (name, battery level, battery is charging, led color) Apr 8, 2022
@YannLocatelli YannLocatelli marked this pull request as ready for review April 8, 2022 19:55
@codecov
Copy link

codecov bot commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #633 (0f7c662) into develop (1694c7e) will increase coverage by 3.83%.
The diff coverage is 100.00%.

❗ Current head 0f7c662 differs from pull request most recent head c33e300. Consider uploading reports for the commit c33e300 to get more accurate results

@@             Coverage Diff             @@
##           develop     #633      +/-   ##
===========================================
+ Coverage    94.34%   98.17%   +3.83%     
===========================================
  Files          103       93      -10     
  Lines         2212     1977     -235     
===========================================
- Hits          2087     1941     -146     
+ Misses         125       36      -89
Impacted Files Coverage Δ
libs/BLEKit/include/BLEKit.h 100.00% <ø> (ø)
libs/BLEKit/include/CoreGap.h 100.00% <ø> (ø)
libs/BLEKit/include/AdvertisingData.h 100.00% <100.00%> (ø)
libs/BLEKit/source/BLEKit.cpp 100.00% <100.00%> (ø)
libs/BLEKit/source/CoreGap.cpp 100.00% <100.00%> (ø)
libs/LogKit/include/LogKit.h 100.00% <0.00%> (ø)
libs/CommandKit/source/CommandKit.cpp 100.00% <0.00%> (ø)
drivers/CoreVideo/source/CoreVideo.cpp 100.00% <0.00%> (ø)
libs/BLEKit/include/BLEServiceUpdate.h 100.00% <0.00%> (ø)
libs/ContainerKit/include/CircularQueue.h 100.00% <0.00%> (ø)
... and 16 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link

github-actions bot commented Apr 8, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 145244 (55%) 116900 (44%) 30048 (5%)
os 318800 (20%) 1245872 (79%) 39488 (7%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 319056 (15%)
318800 (15%)		 📉
-256 (0%)		 39480 (7%)
39488 (7%)		 📈
8 (0%)
bootloader ✔️ ✅ ✅ 145244 (6%) ø 30048 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 258248 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 194032 (9%) ø 30384 (5%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 151960 (7%) ø 21648 (4%) ø
spike_lk_ble ✔️ ❌ ❌ 224836 (10%)
224708 (10%)		 📉
-128 (0%)		 33584 (6%)
33592 (6%)		 📈
8 (0%)
spike_lk_bluetooth ✔️ ✅ ✅ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152104 (7%) ø 52488 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88992 (4%) ø 19744 (3%) ø
spike_lk_command_kit ✔️ ✅ ✅ 156752 (7%) ø 22560 (4%) ø
spike_lk_config_kit ✔️ ✅ ✅ 136740 (6%) ø 20368 (3%) ø
spike_lk_coreled ✔️ ✅ ✅ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 127820 (6%) ø 20216 (3%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331692 (15%) ø 33536 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 158728 (7%) ø 52136 (9%) ø
spike_lk_led ✔️ ✅ ✅ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115724 (5%) ø 20608 (3%) ø
spike_lk_log_kit ✔️ ✅ ✅ 85016 (4%) ø 18512 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86576 (4%) ø 17552 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 111852 (5%) ø 20608 (3%) ø
spike_lk_rfid ✔️ ✅ ✅ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87600 (4%) ø 18584 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 92248 (4%) ø 17632 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 82752 (3%) ø 17648 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 145268 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-04-20 13:51:01.932348439 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2022-04-20 13:51:02.356385932 +0000
@@ -1,39 +1,39 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       474(+474) |     13(+13) |     157(+157) |
-| [lib]/BLEKit.a          |     1198(+1198) |       0(+0) |         0(+0) |
+| [fill]                  |       476(+476) |     13(+13) |     157(+157) |
+| [lib]/BLEKit.a          |     1066(+1066) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a     |     1228(+1228) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a        |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a      |     2216(+2216) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a  |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a         |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a       |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |       812(+812) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a          |   19198(+19198) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/Utils.a           |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   42284(+42284) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       564(+564) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 161378(+161378) |   769(+769) | 19647(+19647) |
+| [lib]/mbed-os-static.a  | 161236(+161236) |   769(+769) | 19647(+19647) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5864(+5864) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   45532(+45532) |   510(+510) | 15183(+15183) |
-| Subtotals               | 292840(+292840) | 3888(+3888) | 35288(+35288) |
-Total Static RAM memory (data + bss): 39176(+39176) bytes
-Total Flash memory (text + data): 296728(+296728) bytes
+| main.cpp.obj            |   45548(+45548) |   510(+510) | 15191(+15191) |
+| Subtotals               | 292584(+292584) | 3888(+3888) | 35296(+35296) |
+Total Static RAM memory (data + bss): 39184(+39184) bytes
+Total Flash memory (text + data): 296472(+296472) bytes
 
Flash used: 318800&nbsp;(15%) / total: 2097152
SRAM used: 39488&nbsp;(7%) / total: 524288
spike_lk_ble (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-04-20 13:51:07.392831249 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2022-04-20 13:51:07.728860962 +0000
@@ -1,19 +1,19 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       424(+424) |       9(+9) |       82(+82) |
-| [lib]/BLEKit.a          |     1198(+1198) |       0(+0) |         0(+0) |
+| [fill]                  |       374(+374) |       9(+9) |       82(+82) |
+| [lib]/BLEKit.a          |     1210(+1210) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       122(+122) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |       768(+768) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   40964(+40964) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       360(+360) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 142782(+142782) |   705(+705) | 19359(+19359) |
+| [lib]/mbed-os-static.a  | 142640(+142640) |   705(+705) | 19359(+19359) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |     6250(+6250) |     78(+78) | 10310(+10310) |
-| Subtotals               | 205668(+205668) | 3376(+3376) | 29920(+29920) |
-Total Static RAM memory (data + bss): 33296(+33296) bytes
-Total Flash memory (text + data): 209044(+209044) bytes
+| main.cpp.obj            |     6302(+6302) |     78(+78) | 10318(+10318) |
+| Subtotals               | 205540(+205540) | 3376(+3376) | 29928(+29928) |
+Total Static RAM memory (data + bss): 33304(+33304) bytes
+Total Flash memory (text + data): 208916(+208916) bytes
 
Flash used: 224708&nbsp;(10%) / total: 2097152
SRAM used: 33592&nbsp;(6%) / total: 524288

@github-actions
Copy link

github-actions bot commented Apr 8, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 145244 (55%) 116900 (44%) 30048 (5%)
os 297908 (19%) 1266764 (80%) 33280 (6%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 298164 (14%)
297908 (14%)		 📉
-256 (0%)		 33272 (6%)
33280 (6%)		 📈
8 (0%)
bootloader ✔️ ✅ ✅ 145244 (6%) ø 30048 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 250688 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177960 (8%) ø 24360 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 142592 (6%) ø 15704 (2%) ø
spike_lk_ble ✔️ ❌ ❌ 215184 (10%)
215056 (10%)		 📉
-128 (0%)		 27512 (5%)
27520 (5%)		 📈
8 (0%)
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 143832 (6%) ø 46488 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65712 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 144856 (6%) ø 16360 (3%) ø
spike_lk_config_kit ✔️ ✅ ✅ 124204 (5%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 103604 (4%) ø 14048 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 326984 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 145768 (6%) ø 46064 (8%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103220 (4%) ø 14664 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63736 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62528 (2%) ø 11488 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 101996 (4%) ø 14664 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 58904 (2%) ø 11464 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 122788 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-04-20 13:50:53.259196011 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2022-04-20 13:50:53.663203756 +0000
@@ -1,39 +1,39 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       492(+492) |     13(+13) |     145(+145) |
-| [lib]/BLEKit.a          |     1198(+1198) |       0(+0) |         0(+0) |
+| [fill]                  |       494(+494) |     13(+13) |     145(+145) |
+| [lib]/BLEKit.a          |     1066(+1066) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a      |       324(+324) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a     |     1228(+1228) |       0(+0) |         0(+0) |
 | [lib]/ColorKit.a        |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a      |     1716(+1716) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a     |       472(+472) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a  |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       116(+116) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a         |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a       |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a       |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a         |         12(+12) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a        |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a         |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a     |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |       812(+812) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a     |       172(+172) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/LedKit.a          |   19198(+19198) |       0(+0) |         0(+0) |
 | [lib]/SerialNumberKit.a |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/Utils.a           |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/bootutil.a        |     1282(+1282) |     12(+12) |     132(+132) |
 | [lib]/c.a               |   42396(+42396) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       204(+204) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 157854(+157854) |   769(+769) | 19611(+19611) |
+| [lib]/mbed-os-static.a  | 157712(+157712) |   769(+769) | 19611(+19611) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     5444(+5444) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   30926(+30926) |   510(+510) |   9023(+9023) |
-| Subtotals               | 273560(+273560) | 3888(+3888) | 29080(+29080) |
-Total Static RAM memory (data + bss): 32968(+32968) bytes
-Total Flash memory (text + data): 277448(+277448) bytes
+| main.cpp.obj            |   30942(+30942) |   510(+510) |   9031(+9031) |
+| Subtotals               | 273304(+273304) | 3888(+3888) | 29088(+29088) |
+Total Static RAM memory (data + bss): 32976(+32976) bytes
+Total Flash memory (text + data): 277192(+277192) bytes
 
Flash used: 297908&nbsp;(14%) / total: 2097152
SRAM used: 33280&nbsp;(6%) / total: 524288
spike_lk_ble (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-04-20 13:50:58.479296079 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2022-04-20 13:50:58.799302213 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       418(+418) |       9(+9) |       86(+86) |
-| [lib]/BLEKit.a          |     1198(+1198) |       0(+0) |         0(+0) |
+| [fill]                  |       368(+368) |       9(+9) |       86(+86) |
+| [lib]/BLEKit.a          |     1210(+1210) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |       154(+154) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |       768(+768) |       0(+0) |         0(+0) |
 | [lib]/c.a               |   40940(+40940) | 2572(+2572) |       97(+97) |
 | [lib]/gcc.a             |     7084(+7084) |       0(+0) |         0(+0) |
-| [lib]/mbed-os-static.a  | 139242(+139242) |   705(+705) | 19323(+19323) |
+| [lib]/mbed-os-static.a  | 139100(+139100) |   705(+705) | 19323(+19323) |
 | [lib]/misc              |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a          |     4116(+4116) |       8(+8) |       28(+28) |
-| main.cpp.obj            |     3760(+3760) |     78(+78) |   4286(+4286) |
-| Subtotals               | 197908(+197908) | 3376(+3376) | 23848(+23848) |
-Total Static RAM memory (data + bss): 27224(+27224) bytes
-Total Flash memory (text + data): 201284(+201284) bytes
+| main.cpp.obj            |     3812(+3812) |     78(+78) |   4294(+4294) |
+| Subtotals               | 197780(+197780) | 3376(+3376) | 23856(+23856) |
+Total Static RAM memory (data + bss): 27232(+27232) bytes
+Total Flash memory (text + data): 201156(+201156) bytes
 
Flash used: 215056&nbsp;(10%) / total: 2097152
SRAM used: 27520&nbsp;(5%) / total: 524288

ladislas
ladislas reviewed Apr 10, 2022
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First read through, it's very interesting 👍

libs/BLEKit/include/BLEKit.h Outdated Show resolved Hide resolved
libs/BLEKit/include/CoreGap.h Outdated Show resolved Hide resolved
libs/BLEKit/include/CoreGap.h Outdated Show resolved Hide resolved
@YannLocatelli YannLocatelli force-pushed the yann/feature/ble/set-battery-level-in-advertising-data branch 3 times, most recently from f0c9afb to 0f7c662 Compare April 11, 2022 12:53
ladislas
ladislas reviewed Apr 14, 2022
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new review. a few suggestions/questions, and we're good to merge

libs/BLEKit/include/AdvertisingData.h Outdated Show resolved Hide resolved
libs/BLEKit/include/CoreGap.h Outdated Show resolved Hide resolved
libs/BLEKit/source/CoreGap.cpp Outdated Show resolved Hide resolved
libs/BLEKit/source/CoreGap.cpp Show resolved Hide resolved
@YannLocatelli YannLocatelli changed the title ⚡️ (ble): Set dynamic data in advertising (name, battery level, battery is charging, led color) ⚡️ (ble): Set dynamic data in advertising (name, battery level, battery is charging) Apr 19, 2022
@YannLocatelli YannLocatelli force-pushed the yann/feature/ble/set-battery-level-in-advertising-data branch from 0f7c662 to 1758171 Compare April 20, 2022 12:33
@YannLocatelli YannLocatelli force-pushed the yann/feature/ble/set-battery-level-in-advertising-data branch from 1758171 to c33e300 Compare April 20, 2022 13:38
@sonarcloud
Copy link

sonarcloud bot commented Apr 20, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit e51e053 into develop Apr 20, 2022
@ladislas ladislas deleted the yann/feature/ble/set-battery-level-in-advertising-data branch April 20, 2022 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas left review comments

Assignees

@YannLocatelli YannLocatelli

Labels
01 - type: task Something to do
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YannLocatelli @ladislas