Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 (style): Remove trailing semicolons on class constructors & functions #636

Merged
merged 2 commits into from
Apr 5, 2022
Merged

🎨 (style): Remove trailing semicolons on class constructors & functions #636

merged 2 commits into from
Apr 5, 2022

Conversation

ladislas
Copy link
Member

@ladislas ladislas commented Apr 4, 2022

No description provided.

@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #636 (0ca6c67) into develop (0026fcb) will increase coverage by 0.00%.
The diff coverage is 97.82%.

@@           Coverage Diff            @@
##           develop     #636   +/-   ##
========================================
  Coverage    98.32%   98.33%           
========================================
  Files           92       92           
  Lines         1910     1918    +8     
========================================
+ Hits          1878     1886    +8     
  Misses          32       32
Impacted Files Coverage Δ
libs/BLEKit/include/BLEServiceCommands.h 40.00% <0.00%> (ø)
drivers/CoreBattery/include/CoreBattery.h 100.00% <100.00%> (ø)
...rs/CoreBufferedSerial/include/CoreBufferedSerial.h 100.00% <100.00%> (ø)
...vers/CoreFlashMemory/include/CoreFlashIS25LP016D.h 100.00% <100.00%> (ø)
...reFlashMemory/include/CoreFlashManagerIS25LP016D.h 100.00% <100.00%> (ø)
drivers/CoreI2C/include/CoreI2C.h 100.00% <100.00%> (ø)
drivers/CoreLED/include/CoreLED.h 100.00% <100.00%> (ø)
drivers/CoreLightSensor/include/CoreLightSensor.h 100.00% <100.00%> (ø)
drivers/CoreMicrophone/include/CoreMicrophone.h 100.00% <100.00%> (ø)
drivers/CoreMotor/include/CoreMotor.h 100.00% <100.00%> (ø)
... and 18 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 145300 (55%) 116844 (44%) 30048 (5%)
os 259368 (16%) 1305304 (83%) 29440 (5%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 259368 (12%) ø 29440 (5%) ø
bootloader ✔️ ✅ ✅ 145300 (6%) ø 30048 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 250624 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174568 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177960 (8%) ø 24360 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 117396 (5%) ø 15432 (2%) ø
spike_lk_ble ✔️ ✅ ✅ 174892 (8%) ø 24672 (4%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 141016 (6%) ø 24416 (4%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65584 (3%) ø 13624 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 119908 (5%) ø 16072 (3%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 326904 (15%) ø 27576 (5%) ø
spike_lk_filesystem_kit ✔️ ✅ ✅ 103540 (4%) ø 14048 (2%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 142584 (6%) ø 23992 (4%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ ✅ ✅ 77336 (3%) ø 14376 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 68528 (3%) ø 11912 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62528 (2%) ø 11488 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 77400 (3%) ø 14376 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 73072 (3%) ø 11448 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 66968 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 58904 (2%) ø 11464 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 122724 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented Apr 4, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 145300 (55%) 116844 (44%) 30048 (5%)
os 269820 (17%) 1294852 (82%) 35584 (6%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 269820 (12%) ø 35584 (6%) ø
bootloader ✔️ ✅ ✅ 145300 (6%) ø 30048 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 258168 (12%) ø 35272 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 191600 (9%) ø 30976 (5%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 165248 (7%) ø 28680 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91928 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 194032 (9%) ø 30384 (5%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 135460 (6%) ø 21416 (4%) ø
spike_lk_ble ✔️ ✅ ✅ 184576 (8%) ø 30752 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 91192 (4%) ø 17472 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 149224 (7%) ø 30416 (5%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88800 (4%) ø 19624 (3%) ø
spike_lk_command_kit ✔️ ✅ ✅ 140188 (6%) ø 22320 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 88556 (4%) ø 19632 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84664 (4%) ø 18136 (3%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331612 (15%) ø 33536 (6%) ø
spike_lk_filesystem_kit ✔️ ✅ ✅ 127740 (6%) ø 20216 (3%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 87352 (4%) ø 17512 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 155544 (7%) ø 30064 (5%) ø
spike_lk_led ✔️ ✅ ✅ 88808 (4%) ø 19400 (3%) ø
spike_lk_led_kit ✔️ ✅ ✅ 96184 (4%) ø 20376 (3%) ø
spike_lk_log_kit ✔️ ✅ ✅ 92000 (4%) ø 18168 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86576 (4%) ø 17552 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 96248 (4%) ø 20376 (3%) ø
spike_lk_rfid ✔️ ✅ ✅ 91008 (4%) ø 17472 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87600 (4%) ø 18584 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 84584 (4%) ø 17512 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 85336 (4%) ø 17512 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90896 (4%) ø 17496 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 92248 (4%) ø 17632 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 82752 (3%) ø 17648 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 83224 (3%) ø 17592 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 145204 (6%) ø 21352 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100968 (4%) ø 18472 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 131280 (6%) ø 20832 (3%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84688 (4%) ø 18448 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 84000 (4%) ø 17536 (3%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@ladislas ladislas force-pushed the ladislas/bugfix/constructor-semicolon branch 2 times, most recently from 1298693 to a4f627f Compare April 4, 2022 14:08
@ladislas ladislas added this to the v1.0.0 milestone Apr 5, 2022
@ladislas ladislas added the 01 - type: task Something to do label Apr 5, 2022
@ladislas ladislas force-pushed the ladislas/bugfix/constructor-semicolon branch from 954360d to 0ca6c67 Compare April 5, 2022 21:01
@ladislas ladislas changed the title 🎨 (style): Remove trailing semicolons on {} constructors 🎨 (style): Remove trailing semicolons on class constructors & functions Apr 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

88.0% 88.0% Coverage
0.0% 0.0% Duplication

@ladislas ladislas merged commit 53b0de8 into develop Apr 5, 2022
@ladislas ladislas deleted the ladislas/bugfix/constructor-semicolon branch April 5, 2022 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
01 - type: task Something to do
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
1 participant
@ladislas