-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hugo/feature/Show charging info on Ble connection/disconnection #765
Merged
ladislas
merged 1 commit into
develop
from
hugo/feature/Show-charging-info-on-Ble-connection/disconnection
May 9, 2022
Merged
hugo/feature/Show charging info on Ble connection/disconnection #765
ladislas
merged 1 commit into
develop
from
hugo/feature/Show-charging-info-on-Ble-connection/disconnection
May 9, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HPezz
commented
May 6, 2022
•
edited
Loading
edited
- 🎨 (sm): Show battery level on BLE even/command received
- ✅ (tests): Add tests to new transitions
HPezz
changed the base branch from
develop
to
hugo/feature/Back-to-Idle-on-Ble-connection/disconnection
May 6, 2022 15:48
Codecov Report
@@ Coverage Diff @@
## develop #765 +/- ##
========================================
Coverage 93.76% 93.77%
========================================
Files 110 110
Lines 2423 2426 +3
========================================
+ Hits 2272 2275 +3
Misses 151 151
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
File comparision analysis report🔖 Info
Click to show memory sections
📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff list
|
HPezz
force-pushed
the
hugo/feature/Back-to-Idle-on-Ble-connection/disconnection
branch
from
May 6, 2022 16:39
88264f8
to
3d514c9
Compare
HPezz
force-pushed
the
hugo/feature/Show-charging-info-on-Ble-connection/disconnection
branch
from
May 6, 2022 16:42
e5353a0
to
89c0e7c
Compare
ladislas
force-pushed
the
hugo/feature/Back-to-Idle-on-Ble-connection/disconnection
branch
from
May 7, 2022 08:02
3d514c9
to
fb114d4
Compare
Base automatically changed from
hugo/feature/Back-to-Idle-on-Ble-connection/disconnection
to
develop
May 7, 2022 11:24
ladislas
force-pushed
the
hugo/feature/Show-charging-info-on-Ble-connection/disconnection
branch
from
May 7, 2022 11:38
89c0e7c
to
cb78f85
Compare
Kudos, SonarCloud Quality Gate passed! |
ladislas
approved these changes
May 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
ladislas
deleted the
hugo/feature/Show-charging-info-on-Ble-connection/disconnection
branch
May 9, 2022 09:57
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.