Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🚸 (video): Center images #808

Merged
merged 1 commit into from
May 23, 2022
Merged

🚸 (video): Center images #808

merged 1 commit into from
May 23, 2022

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented May 22, 2022 •
edited
Loading

Essentially for pictos

  • Validated on robot

@YannLocatelli YannLocatelli added this to the v1.0.0 milestone May 22, 2022
@YannLocatelli YannLocatelli self-assigned this May 22, 2022
@YannLocatelli YannLocatelli linked an issue May 22, 2022 that may be closed by this pull request
Video - Set image at center of the screen #668
Closed
@codecov
Copy link

codecov bot commented May 22, 2022

Codecov Report

Merging #808 (8cdd254) into develop (b184e1e) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff            @@
##           develop     #808   +/-   ##
========================================
  Coverage    94.89%   94.90%           
========================================
  Files          115      115           
  Lines         2489     2493    +4     
========================================
+ Hits          2362     2366    +4     
  Misses         127      127
Impacted Files Coverage Δ
drivers/CoreVideo/source/CoreDMA2D.cpp 100.00% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@github-actions
Copy link

github-actions bot commented May 22, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 168172 (64%) 93972 (35%) 30736 (5%)
os 351360 (22%) 1213312 (77%) 72240 (13%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 351360 (16%) ø 72240 (13%) ø
bootloader ✔️ ✅ ✅ 168172 (8%) ø 30736 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 250704 (11%) ø 29240 (5%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 174584 (8%) ø 24952 (4%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 148840 (7%) ø 22528 (4%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 92008 (4%) ø 16168 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 177976 (8%) ø 24360 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 186892 (8%) ø 48064 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 225376 (10%) ø 27928 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 73256 (3%) ø 11448 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144632 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65712 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 189632 (9%) ø 50872 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 124204 (5%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 128680 (6%) ø 14384 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 326984 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 167340 (7%) ø 47288 (9%) ø
spike_lk_led ✔️ ✅ ✅ 65744 (3%) ø 13392 (2%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103460 (4%) ø 14592 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63736 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 102620 (4%) ø 14592 (2%) ø
spike_lk_rfid ✔️ ✅ ✅ 78580 (3%) ø 11504 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 58904 (2%) ø 11464 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 122788 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@github-actions
Copy link

github-actions bot commented May 22, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 167532 (63%) 94612 (36%) 30832 (5%)
os 373836 (23%) 1190836 (76%) 79296 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 373836 (17%) ø 79296 (15%) ø
bootloader ✔️ ✅ ✅ 167532 (7%) ø 30832 (5%) ø
certs_emc_ble_bt_lcd_led_motors ✔️ ✅ ✅ 257608 (12%) ø 35872 (6%) ø
certs_emc_ble_led_motors ✔️ ✅ ✅ 190960 (9%) ø 31512 (6%) ø
certs_emc_bt_lcd_qspi_rfid_touch_wifi ✔️ ✅ ✅ 164608 (7%) ø 29344 (5%) ø
certs_emc_lcd_led_motors ✔️ ✅ ✅ 91304 (4%) ø 16264 (3%) ø
hardware_motors_test_reduction_and_wheels ✔️ ✅ ✅ 193408 (9%) ø 30920 (5%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 195540 (9%) ø 54480 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 233404 (11%) ø 34584 (6%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 90616 (4%) ø 18016 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152200 (7%) ø 53064 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88352 (4%) ø 20216 (3%) ø
spike_lk_command_kit ✔️ ✅ ✅ 199892 (9%) ø 57800 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 136100 (6%) ø 20976 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 87916 (4%) ø 20104 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84088 (4%) ø 18744 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 143648 (6%) ø 21304 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331052 (15%) ø 34072 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86712 (4%) ø 18056 (3%) ø
spike_lk_lcd ✔️ ✅ ✅ 176972 (8%) ø 53960 (10%) ø
spike_lk_led ✔️ ✅ ✅ 88168 (4%) ø 19872 (3%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115420 (5%) ø 21008 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84440 (4%) ø 19248 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86008 (4%) ø 18088 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 111836 (5%) ø 21008 (4%) ø
spike_lk_rfid ✔️ ✅ ✅ 85208 (4%) ø 18032 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 86960 (4%) ø 19120 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 83944 (4%) ø 18056 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84696 (4%) ø 18056 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90336 (4%) ø 18032 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91608 (4%) ø 18296 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 82176 (3%) ø 18320 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82584 (3%) ø 18072 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 144564 (6%) ø 21896 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100328 (4%) ø 19080 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 130640 (6%) ø 21368 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84112 (4%) ø 18920 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83424 (3%) ø 18144 (3%) ø

🗺️ Map files diff output

Click to show diff list

No differenes where found in map files.

@YannLocatelli @ladislas
🚸 (video): Center images
c217a95 
Essentially for pictos
@ladislas ladislas force-pushed the yann/feature/videokit/center-image branch from 8cdd254 to c217a95 Compare May 23, 2022 15:23
@ladislas ladislas merged commit 01953ca into develop May 23, 2022
@ladislas ladislas deleted the yann/feature/videokit/center-image branch May 23, 2022 15:26
@sonarcloud
Copy link

sonarcloud bot commented May 23, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas approved these changes

@HPezz HPezz Awaiting requested review from HPezz

Assignees

@YannLocatelli YannLocatelli

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.

Video - Set image at center of the screen
2 participants
@YannLocatelli @ladislas