✨ (bluetooth): Enable audio to play from bluetooth #921

YannLocatelli · 2022-06-27T12:20:03Z

Validated on the robot

codecov · 2022-06-27T12:22:33Z

Codecov Report

Merging #921 (4496158) into develop (00cb77f) will not change coverage.
The diff coverage is n/a.

❗ Current head 4496158 differs from pull request most recent head 656a95f. Consider uploading reports for the commit 656a95f to get more accurate results

@@           Coverage Diff            @@
##           develop     #921   +/-   ##
========================================
  Coverage    95.54%   95.54%           
========================================
  Files          117      117           
  Lines         2670     2670           
========================================
  Hits          2551     2551           
  Misses         119      119

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

github-actions · 2022-06-27T12:33:17Z

File comparision analysis report

🔖 Info

base: develop / 0919413 + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/bluetooth/enable-audio / 0919413 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	168820 (64%)	93324 (35%)	30920 (5%)
os	363608 (23%)	1201064 (76%)	73736 (14%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	363608 (17%)	ø	73736 (14%)	ø
bootloader	✔️	✅	✅	168820 (8%)	ø	30920 (5%)	ø
spike_lk_audio	✔️	✅	✅	122324 (5%)	ø	14568 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	187568 (8%)	ø	48112 (9%)	ø
spike_lk_ble	✔️	✅	✅	225792 (10%)	ø	28056 (5%)	ø
spike_lk_bluetooth	✔️	❌	❌	73256 (3%) 82948 (3%)	📈 9692 (13%)	11448 (2%) 11544 (2%)	📈 96 (0%)
spike_lk_cg_animations	✔️	✅	✅	144632 (6%)	ø	46528 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65712 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	189760 (9%)	ø	50928 (9%)	ø
spike_lk_config_kit	✔️	✅	✅	124188 (5%)	ø	14312 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76164 (3%)	ø	13688 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74736 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	128680 (6%)	ø	14384 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	326968 (15%)	ø	27576 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	171728 (8%)	ø	47880 (9%)	ø
spike_lk_lcd	✔️	✅	✅	167468 (7%)	ø	47320 (9%)	ø
spike_lk_led_kit	✔️	✅	✅	103992 (4%)	ø	14608 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63736 (3%)	ø	12256 (2%)	ø
spike_lk_motors	✔️	✅	✅	62600 (2%)	ø	11488 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	103480 (4%)	ø	14608 (2%)	ø
spike_lk_rfid	✔️	✅	✅	78644 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78196 (3%)	ø	12568 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67048 (3%)	ø	11424 (2%)	ø
spike_lk_sensors_touch	✔️	✅	✅	68600 (3%)	ø	11432 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	58904 (2%)	ø	11480 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	122804 (5%)	ø	15288 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	79964 (3%)	ø	13296 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116392 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	57968 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_bluetooth (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_bluetooth-map.txt	2022-07-15 08:17:39.266603893 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_bluetooth-map.txt	2022-07-15 08:17:39.482606794 +0000
@@ -1,16 +1,17 @@
 | Module                 |         .text |       .data |        .bss |
 |------------------------|---------------|-------------|-------------|
-| [fill]                 |     110(+110) |       8(+8) |     16(+16) |
+| BM64Converter.cpp.obj  |       76(+76) |       0(+0) |       0(+0) |
+| LekaBluetooth.cpp.obj  |   1050(+1050) |       6(+6) |       0(+0) |
+| [fill]                 |     138(+138) |     10(+10) |     20(+20) |
 | [lib]/HelloWorld.a     |       94(+94) |       0(+0) |       0(+0) |
-| [lib]/_LekaBluetooth.a |     968(+968) |       0(+0) |       0(+0) |
-| [lib]/c.a              | 33032(+33032) | 2472(+2472) |     58(+58) |
-| [lib]/gcc.a            |   3116(+3116) |       0(+0) |       0(+0) |
-| [lib]/mbed-os-static.a | 28820(+28820) |   444(+444) | 8138(+8138) |
+| [lib]/c.a              | 33592(+33592) | 2472(+2472) |     58(+58) |
+| [lib]/gcc.a            |   6924(+6924) |       0(+0) |       0(+0) |
+| [lib]/mbed-os-static.a | 27218(+27218) |   444(+444) | 8130(+8130) |
 | [lib]/misc             |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a          |       32(+32) |       0(+0) |       0(+0) |
-| [lib]/stdc++.a         |         0(+0) |       0(+0) |       0(+0) |
-| main.cpp.obj           |     264(+264) |       0(+0) |       0(+0) |
-| Subtotals              | 66624(+66624) | 2928(+2928) | 8240(+8240) |
-Total Static RAM memory (data + bss): 11168(+11168) bytes
-Total Flash memory (text + data): 69552(+69552) bytes
+| [lib]/stdc++.a         |   5356(+5356) |       8(+8) |     44(+44) |
+| main.cpp.obj           |     152(+152) |       0(+0) |     32(+32) |
+| Subtotals              | 74820(+74820) | 2944(+2944) | 8312(+8312) |
+Total Static RAM memory (data + bss): 11256(+11256) bytes
+Total Flash memory (text + data): 77764(+77764) bytes

Flash used: 82948&nbsp;(3%) / total: 2097152
SRAM used: 11544&nbsp;(2%) / total: 524288

github-actions · 2022-06-27T12:33:38Z

File comparision analysis report

🔖 Info

base: develop / 0919413 + mbed-os-6.15.1+fixes + -std=c++20
head: yann/feature/bluetooth/enable-audio / 0919413 + mbed-os-6.15.1+fixes + -std=c++20
toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

Target	Flash Used (%)	Flash Available (%)	Static RAM (%)
bootloader	181260 (69%)	80884 (30%)	37456 (7%)
os	397996 (25%)	1166676 (74%)	80792 (15%)

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	397996 (18%)	ø	80792 (15%)	ø
bootloader	✔️	✅	✅	181260 (8%)	ø	37456 (7%)	ø
spike_lk_audio	✔️	✅	✅	132380 (6%)	ø	20984 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	196052 (9%)	ø	54528 (10%)	ø
spike_lk_ble	✔️	✅	✅	233676 (11%)	ø	34712 (6%)	ø
spike_lk_bluetooth	✔️	❌	❌	90616 (4%) 92236 (4%)	📈 1620 (1%)	18016 (3%) 18064 (3%)	📈 48 (0%)
spike_lk_cg_animations	✔️	✅	✅	152200 (7%)	ø	53064 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88352 (4%)	ø	20216 (3%)	ø
spike_lk_command_kit	✔️	✅	✅	199956 (9%)	ø	57856 (11%)	ø
spike_lk_config_kit	✔️	✅	✅	136100 (6%)	ø	20976 (4%)	ø
spike_lk_coreled	✔️	✅	✅	87916 (4%)	ø	20104 (3%)	ø
spike_lk_event_queue	✔️	✅	✅	84088 (4%)	ø	18744 (3%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	143648 (6%)	ø	21304 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	331036 (15%)	ø	34072 (6%)	ø
spike_lk_flash_memory	✔️	✅	✅	86712 (4%)	ø	18056 (3%)	ø
spike_lk_fs	✔️	✅	✅	171024 (8%)	ø	47968 (9%)	ø
spike_lk_lcd	✔️	✅	✅	177100 (8%)	ø	53992 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115708 (5%)	ø	21024 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84440 (4%)	ø	19248 (3%)	ø
spike_lk_motors	✔️	✅	✅	86008 (4%)	ø	18088 (3%)	ø
spike_lk_reinforcer	✔️	✅	✅	112188 (5%)	ø	21024 (4%)	ø
spike_lk_rfid	✔️	✅	✅	84512 (4%)	ø	18032 (3%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87056 (4%)	ø	19120 (3%)	ø
spike_lk_sensors_light	✔️	✅	✅	83944 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84696 (4%)	ø	18056 (3%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90336 (4%)	ø	18032 (3%)	ø
spike_lk_sensors_touch	✔️	✅	✅	91608 (4%)	ø	18296 (3%)	ø
spike_lk_serial_number	✔️	✅	✅	82176 (3%)	ø	18336 (3%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	82584 (3%)	ø	18072 (3%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	144644 (6%)	ø	21896 (4%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100328 (4%)	ø	19080 (3%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	88152 (4%)	ø	20120 (3%)	ø
spike_lk_wifi	✔️	✅	✅	130640 (6%)	ø	21368 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84112 (4%)	ø	18920 (3%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83424 (3%)	ø	18144 (3%)	ø

🗺️ Map files diff output

Click to show diff list

spike_lk_bluetooth (click to expand)

--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_bluetooth-map.txt	2022-07-15 08:17:03.754796840 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_bluetooth-map.txt	2022-07-15 08:17:03.938798919 +0000
@@ -1,18 +1,19 @@
 | Module                  |         .text |       .data |          .bss |
 |-------------------------|---------------|-------------|---------------|
-| [fill]                  |     140(+140) |       8(+8) |       28(+28) |
+| BM64Converter.cpp.obj   |       76(+76) |       0(+0) |         0(+0) |
+| LekaBluetooth.cpp.obj   |   3302(+3302) |       6(+6) |   6408(+6408) |
+| [fill]                  |     110(+110) |     10(+10) |       28(+28) |
 | [lib]/CriticalSection.a |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a      |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/_LekaBluetooth.a  |     968(+968) |       0(+0) |         0(+0) |
-| [lib]/c.a               | 32684(+32684) | 2472(+2472) |       58(+58) |
+| [lib]/c.a               | 32512(+32512) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a             |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a               |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 31638(+31638) |   444(+444) |   8226(+8226) |
 | [lib]/misc              |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a           |       32(+32) |       0(+0) |         0(+0) |
-| [lib]/stdc++.a          |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj            |   2520(+2520) |       0(+0) |   6408(+6408) |
-| Subtotals               | 81204(+81204) | 2936(+2936) | 14792(+14792) |
-Total Static RAM memory (data + bss): 17728(+17728) bytes
-Total Flash memory (text + data): 84140(+84140) bytes
+| [lib]/stdc++.a          |   5864(+5864) |       8(+8) |       44(+44) |
+| main.cpp.obj            |   1216(+1216) |       0(+0) |       32(+32) |
+| Subtotals               | 82548(+82548) | 2944(+2944) | 14824(+14824) |
+Total Static RAM memory (data + bss): 17768(+17768) bytes
+Total Flash memory (text + data): 85492(+85492) bytes

Flash used: 92236&nbsp;(4%) / total: 2097152
SRAM used: 18064&nbsp;(3%) / total: 524288

HPezz

LGTM

ladislas

LGTM 👍

Use a counter reset on message received

sonarcloud · 2022-07-15T08:28:32Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

YannLocatelli added the 01 - type: task Something to do label Jun 27, 2022

YannLocatelli added this to the Future releases milestone Jun 27, 2022

YannLocatelli self-assigned this Jun 27, 2022

YannLocatelli removed this from the Future releases milestone Jun 27, 2022

YannLocatelli force-pushed the yann/feature/bluetooth/enable-audio branch from abdb427 to 2606354 Compare July 5, 2022 14:39

YannLocatelli marked this pull request as ready for review July 5, 2022 14:40

YannLocatelli force-pushed the yann/feature/bluetooth/enable-audio branch from 2606354 to 7139645 Compare July 5, 2022 15:11

HPezz approved these changes Jul 6, 2022

View reviewed changes

YannLocatelli mentioned this pull request Jul 12, 2022

♻️ (bluetooth): clang-tidy warnings #934

Merged

2 tasks

YannLocatelli force-pushed the yann/feature/bluetooth/enable-audio branch from 7139645 to 4496158 Compare July 12, 2022 14:14

ladislas approved these changes Jul 15, 2022

View reviewed changes

YannLocatelli added 4 commits July 15, 2022 10:06

✨ (bluetooth): Enable audio to play from bluetooth

a5bd949

🚸 (bluetooth): Repairing if bluetooth not used

49a6c44

Use a counter reset on message received

🚚 (bluetooth): Move LekaBluetooth from InvestigationDay lib to spike

fb15920

♻️ (bluetooth): clang-tidy warnings

adec667

ladislas force-pushed the yann/feature/bluetooth/enable-audio branch from 656a95f to adec667 Compare July 15, 2022 08:06

ladislas merged commit 0919413 into develop Jul 15, 2022

ladislas deleted the yann/feature/bluetooth/enable-audio branch July 15, 2022 08:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

✨ (bluetooth): Enable audio to play from bluetooth #921

✨ (bluetooth): Enable audio to play from bluetooth #921

YannLocatelli commented Jun 27, 2022 •

edited

Loading

codecov bot commented Jun 27, 2022 •

edited

Loading

github-actions bot commented Jun 27, 2022 •

edited

Loading

github-actions bot commented Jun 27, 2022 •

edited

Loading

HPezz left a comment

ladislas left a comment

sonarcloud bot commented Jul 15, 2022

✨ (bluetooth): Enable audio to play from bluetooth #921

✨ (bluetooth): Enable audio to play from bluetooth #921

Conversation

YannLocatelli commented Jun 27, 2022 • edited Loading

codecov bot commented Jun 27, 2022 • edited Loading

Codecov Report

github-actions bot commented Jun 27, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

github-actions bot commented Jun 27, 2022 • edited Loading

File comparision analysis report

🔖 Info

📝 Summary

🗺️ Map files diff output

HPezz left a comment

Choose a reason for hiding this comment

ladislas left a comment

Choose a reason for hiding this comment

sonarcloud bot commented Jul 15, 2022

YannLocatelli commented Jun 27, 2022 •

edited

Loading

codecov bot commented Jun 27, 2022 •

edited

Loading

github-actions bot commented Jun 27, 2022 •

edited

Loading

github-actions bot commented Jun 27, 2022 •

edited

Loading