Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ (spikes): Show MagicCard ID in lk_rfid #948

Merged
merged 1 commit into from
Jul 26, 2022
Merged

✨ (spikes): Show MagicCard ID in lk_rfid #948

merged 1 commit into from
Jul 26, 2022

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Jul 26, 2022

No description provided.

@ladislas ladislas merged commit 68b3893 into develop Jul 26, 2022
@ladislas ladislas deleted the Update-lk_rfid branch July 26, 2022 14:53
@ladislas ladislas added the 01 - type: task Something to do label Jul 26, 2022
@ladislas ladislas added this to the Next Release milestone Jul 26, 2022
@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

  • base: develop / 68b3893 + mbed-os-6.15.1+fixes + -std=c++20
  • head: Update-lk_rfid / 68b3893 + mbed-os-6.15.1+fixes + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: ON
Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 181260 (69%) 80884 (30%) 37456 (7%)
os 397996 (25%) 1166676 (74%) 80792 (15%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 397996 (18%) ø 80792 (15%) ø
bootloader ✔️ ✅ ✅ 181260 (8%) ø 37456 (7%) ø
spike_lk_audio ✔️ ✅ ✅ 132380 (6%) ø 20984 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 196052 (9%) ø 54528 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 233676 (11%) ø 34712 (6%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 92236 (4%) ø 18064 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 152200 (7%) ø 53064 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 88352 (4%) ø 20216 (3%) ø
spike_lk_command_kit ✔️ ✅ ✅ 199956 (9%) ø 57856 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 136100 (6%) ø 20976 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 87916 (4%) ø 20104 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 84088 (4%) ø 18744 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 143648 (6%) ø 21304 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 331036 (15%) ø 34072 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 86712 (4%) ø 18056 (3%) ø
spike_lk_fs ✔️ ✅ ✅ 171024 (8%) ø 47968 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 177100 (8%) ø 53992 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 115708 (5%) ø 21024 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 84440 (4%) ø 19248 (3%) ø
spike_lk_motors ✔️ ✅ ✅ 86008 (4%) ø 18088 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 112188 (5%) ø 21024 (4%) ø
spike_lk_rfid ✔️ ❌ ❌ 84512 (4%)
84920 (4%)		 📈
408 (0%)		 18032 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 87056 (4%) ø 19120 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 83944 (4%) ø 18056 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 84696 (4%) ø 18056 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 90336 (4%) ø 18032 (3%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 91608 (4%) ø 18296 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 82176 (3%) ø 18336 (3%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 82584 (3%) ø 18072 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 144644 (6%) ø 21896 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 100328 (4%) ø 19080 (3%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 88152 (4%) ø 20120 (3%) ø
spike_lk_wifi ✔️ ✅ ✅ 130640 (6%) ø 21368 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57616 (2%) ø 11496 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 84112 (4%) ø 18920 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 83424 (3%) ø 18144 (3%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_rfid (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_rfid-map.txt	2022-07-26 15:06:49.443414035 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_rfid-map.txt	2022-07-26 15:06:49.671415283 +0000
@@ -1,20 +1,20 @@
 | Module                     |         .text |       .data |          .bss |
 |----------------------------|---------------|-------------|---------------|
-| [fill]                     |     158(+158) |       8(+8) |       28(+28) |
+| [fill]                     |     174(+174) |       8(+8) |       28(+28) |
 | [lib]/CoreBufferedSerial.a |     108(+108) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |     778(+778) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a    |         8(+8) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |         0(+0) |
-| [lib]/RFIDKit.a            |   1782(+1782) |       0(+0) |     136(+136) |
+| [lib]/RFIDKit.a            |   1870(+1870) |       0(+0) |         8(+8) |
 | [lib]/c.a                  | 25048(+25048) | 2472(+2472) |       58(+58) |
 | [lib]/gcc.a                |   7148(+7148) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     360(+360) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 31638(+31638) |   444(+444) |   8226(+8226) |
 | [lib]/misc                 |     188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++.a             |   5424(+5424) |       8(+8) |       44(+44) |
-| main.cpp.obj               |   2390(+2390) |       0(+0) |   6280(+6280) |
-| Subtotals                  | 75156(+75156) | 2936(+2936) | 14800(+14800) |
+| main.cpp.obj               |   2670(+2670) |       0(+0) |   6408(+6408) |
+| Subtotals                  | 75540(+75540) | 2936(+2936) | 14800(+14800) |
 Total Static RAM memory (data + bss): 17736(+17736) bytes
-Total Flash memory (text + data): 78092(+78092) bytes
+Total Flash memory (text + data): 78476(+78476) bytes
 
Flash used: 84920 (4%) / total: 2097152
SRAM used: 18032 (3%) / total: 524288

@github-actions
Copy link

github-actions bot commented Jul 26, 2022 •
edited
Loading

File comparision analysis report

🔖 Info

  • base: develop / 68b3893 + mbed-os-6.15.1+fixes + -std=c++20
  • head: Update-lk_rfid / 68b3893 + mbed-os-6.15.1+fixes + -std=c++20
  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: OFF
Target Flash Used (%) Flash Available (%) Static RAM (%)
bootloader 168820 (64%) 93324 (35%) 30920 (5%)
os 363608 (23%) 1201064 (76%) 73736 (14%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

📝 Summary

Click to show summary
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ✅ ✅ 363608 (17%) ø 73736 (14%) ø
bootloader ✔️ ✅ ✅ 168820 (8%) ø 30920 (5%) ø
spike_lk_audio ✔️ ✅ ✅ 122324 (5%) ø 14568 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 187568 (8%) ø 48112 (9%) ø
spike_lk_ble ✔️ ✅ ✅ 225792 (10%) ø 28056 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 82948 (3%) ø 11544 (2%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 144632 (6%) ø 46528 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 65712 (3%) ø 13744 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 189760 (9%) ø 50928 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 124188 (5%) ø 14312 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 76164 (3%) ø 13688 (2%) ø
spike_lk_event_queue ✔️ ✅ ✅ 74736 (3%) ø 12072 (2%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 128680 (6%) ø 14384 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 326968 (15%) ø 27576 (5%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 63880 (3%) ø 11448 (2%) ø
spike_lk_fs ✔️ ✅ ✅ 171728 (8%) ø 47880 (9%) ø
spike_lk_lcd ✔️ ✅ ✅ 167468 (7%) ø 47320 (9%) ø
spike_lk_led_kit ✔️ ✅ ✅ 103992 (4%) ø 14608 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 63736 (3%) ø 12256 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 62600 (2%) ø 11488 (2%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 103480 (4%) ø 14608 (2%) ø
spike_lk_rfid ✔️ ❌ ❌ 78644 (3%)
78772 (3%)		 📈
128 (0%)		 11504 (2%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 78196 (3%) ø 12568 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 60056 (2%) ø 11440 (2%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 72496 (3%) ø 11504 (2%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 67048 (3%) ø 11424 (2%) ø
spike_lk_sensors_touch ✔️ ✅ ✅ 68600 (3%) ø 11432 (2%) ø
spike_lk_serial_number ✔️ ✅ ✅ 58904 (2%) ø 11480 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 69052 (3%) ø 11632 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 122804 (5%) ø 15288 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 77632 (3%) ø 12352 (2%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 79964 (3%) ø 13296 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 116392 (5%) ø 14808 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 57968 (2%) ø 11400 (2%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 63208 (3%) ø 12448 (2%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 58456 (2%) ø 11400 (2%) ø

🗺️ Map files diff output

Click to show diff list
spike_lk_rfid (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_rfid-map.txt	2022-07-26 15:04:48.162101234 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_rfid-map.txt	2022-07-26 15:04:48.338102589 +0000
@@ -1,18 +1,18 @@
 | Module                     |         .text |       .data |        .bss |
 |----------------------------|---------------|-------------|-------------|
-| [fill]                     |     150(+150) |       8(+8) |     20(+20) |
+| [fill]                     |     142(+142) |       8(+8) |     20(+20) |
 | [lib]/CoreBufferedSerial.a |     108(+108) |       0(+0) |       0(+0) |
 | [lib]/CoreRFIDReader.a     |     810(+810) |       0(+0) |       0(+0) |
 | [lib]/HelloWorld.a         |       94(+94) |       0(+0) |       0(+0) |
-| [lib]/RFIDKit.a            |     860(+860) |       0(+0) |       8(+8) |
+| [lib]/RFIDKit.a            |     948(+948) |       0(+0) |       8(+8) |
 | [lib]/c.a                  | 26128(+26128) | 2472(+2472) |     58(+58) |
 | [lib]/gcc.a                |   7084(+7084) |       0(+0) |       0(+0) |
 | [lib]/mbed-os-static.a     | 31130(+31130) |   444(+444) | 8138(+8138) |
 | [lib]/misc                 |     188(+188) |       4(+4) |     28(+28) |
 | [lib]/nosys.a              |       32(+32) |       0(+0) |       0(+0) |
 | [lib]/stdc++.a             |   4116(+4116) |       8(+8) |     28(+28) |
-| main.cpp.obj               |     344(+344) |       0(+0) |       0(+0) |
-| Subtotals                  | 71044(+71044) | 2936(+2936) | 8280(+8280) |
+| main.cpp.obj               |     392(+392) |       0(+0) |       0(+0) |
+| Subtotals                  | 71172(+71172) | 2936(+2936) | 8280(+8280) |
 Total Static RAM memory (data + bss): 11216(+11216) bytes
-Total Flash memory (text + data): 73980(+73980) bytes
+Total Flash memory (text + data): 74108(+74108) bytes
 
Flash used: 78772 (3%) / total: 2097152
SRAM used: 11504 (2%) / total: 524288

@sonarcloud
Copy link

sonarcloud bot commented Jul 26, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas approved these changes

Assignees

@HPezz HPezz

Labels
01 - type: task Something to do
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@HPezz @ladislas