hugo/feature/Move RFIDKit in RC #992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HPezz
commented
Sep 2, 2022
HPezz
commented
- ⚡ (rc): Move RFIDKit and emrgencyStop in RC
- ♻️ (os): Update OS
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
File comparision analysis report🔖 Info
Click to show memory sections📝 SummaryClick to show summary
🗺️ Map files diff outputClick to show diff listNo differenes where found in map files. |
HPezz
force-pushed
the
hugo/feature/Move-RFIDKit-in-RC
branch
from
461c62c
to
0b5079e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #992 +/- ##
========================================
Coverage 95.97% 95.98%
========================================
Files 127 127
Lines 2957 2963 +6
========================================
+ Hits 2838 2844 +6
Misses 119 119
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
HPezz
force-pushed
the
hugo/feature/Move-RFIDKit-in-RC
branch
2 times, most recently
from
1f8aaee
to
be2f30c
Compare
ladislas
requested changes
Sep 4, 2022
Comment on lines
270
to
276
| void emergencyStop(const MagicCard &card) | ||
| { | ||
| if (card == MagicCard::emergency_stop) { | ||
| raiseEmergencyStop(); | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
je trouve qu'un emergency stop qui prend une carte c'est bizarre.
le emergency stop il doit juste raise l'event et stopper le robot.
le if il doit aller dans le call back
| void registerEvents() | ||
| { | ||
| using namespace system::robot::sm; | ||
|
|
||
| // Setup callbacks for monitoring | ||
|
|
||
| _rfidkit.onTagActivated([this](const MagicCard &card) { emergencyStop(card); }); |
app/os/main.cpp
Outdated
| display::videokit, | ||
| behaviorkit, | ||
| commandkit, | ||
| rfidkit}; |
There was a problem hiding this comment.
remettre une virgule ici
Suggested change
| rfidkit}; | |
| rfidkit,}; |
HPezz
force-pushed
the
hugo/feature/Move-RFIDKit-in-RC
branch
from
be2f30c
to
0111257
Compare
ladislas
force-pushed
the
hugo/feature/Move-RFIDKit-in-RC
branch
from
0111257
to
62af1fa
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.