Add progress callback #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- source of isFunction() : http://stackoverflow.com/questions/5999998/how-can-i-check-if-a-javascri pt-variable-is-function-type - replace file.progress property with a callback
| @@ -102,11 +103,20 @@ var ReactQiniu = React.createClass({ | |||
| .field('x:size', file.size) | |||
| .attach('file', file, file.name) | |||
| .set('Accept', 'application/json') | |||
| .on('progress', function (e) { file.progress = e.percent;}) | |||
| .on('progress', function (e) { | |||
| if(me.isFunction(file.progress)){ | |||
There was a problem hiding this comment.
file.progress 这个 callback 可以通过什么方式传进来？
There was a problem hiding this comment.
在onDrop()拿到files对象的时候，可以给每个file定义.progress()，其实也就是把之前的progress属性变成了progress()方法
There was a problem hiding this comment.
嗯， 我在考虑直接返回这个 request 对象, 这样的话 不仅可以用 on 来获取 progress, 而且也可以用 .promise()
There was a problem hiding this comment.
试了一下，返回 request 只能拿到上传完成后的值 100%， 拿不到变化的值，还是用 callback 的方法吧 :)
|
Thanks @AndreLion , even we have callback now, but it still doesn't work well, i will fix it later |
|
npm上的代码什么时候会生效呢？还需要 @lingochamp 来操作吗？ |
|
不需要， 我马上会发一个新版本 0.3.0 |
|
@AndreLion npm 上的已经是最新的版本了，另外你也可以在 http://lenage.com/react-qiniu/ 看看 demo, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://stackoverflow.com/questions/5999998/how-can-i-check-if-a-javascript-variable-is-function-type