-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add RaveShareMintOAV0 details #8
Conversation
|
Some comments:
function processPublicationAction(
Types.ProcessActionParams calldata params
) external override returns (bytes memory) {
// ...
}
event Log(string variable, string message);
event Log(string variable, address message);
event Log(string variable, int message); |
hey @donosonaumczuk , 1/2 were for testing purpose, I have updated the PR with the updated contract address, which you can find at https://polygonscan.com/address/0x410688fc60028c805bdf8592a6504a0096927911#code |
Great, looks good to me now @thearyanag |
Needs a rebase please @thearyanag |
Instead of
you can verify that |
hey @joshstevens19 , did the rebases, check now |
hey @vicnaum , thanks for the suggestion, that line is intended as we want to start this as a piolet module and iterate based on user feedback , in the coming module we'll open up the support for all token. |
we can merge this but you need to rebase it has conflicts with base @thearyanag |
hey @joshstevens19 , I did the rebase earlier , I suppose with the recent changes to the base, there were conflicts, I rebased it again, check now |
Verify my module