feat: add server name to sentry init #217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
panuhorsmalahti
commented
Jun 25, 2024
panuhorsmalahti
commented
- https://docs.sentry.io/platforms/java/configuration/options/#server-name
- Makes it easier to link the Sentry errors to the actual server
jweak
reviewed
Jun 25, 2024
| @@ -35,4 +38,4 @@ process.once("SIGINT", () => { | |||
| process.exit(0); | |||
| }); | |||
|
|
|||
| server.start(serverPort, agentToken, idpPublicKey); | |||
| server.start(serverPort, agentToken, idpPublicKey, tunnelAddress); | |||
There was a problem hiding this comment.
is the tunnelAddress added to the server.start function or did I miss something?
There was a problem hiding this comment.
It was already there as optional parameter
jweak
reviewed
Jun 25, 2024
| if (process.env.SENTRY_DSN) { | ||
| enabled = true; | ||
| Sentry.init({ | ||
| dsn: process.env.SENTRY_DSN | ||
| dsn: process.env.SENTRY_DSN, | ||
| serverName: tunnelAddress |
There was a problem hiding this comment.
You could use the process.env.TUNNEL_ADDRESS straight here as this already looks for the process.env
There was a problem hiding this comment.
I wanted to use single source of truth for tunnelAddress
jweak
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.