Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top-bar .separator width #6706

Merged
merged 1 commit into from
Dec 6, 2022
Merged

Conversation

aleksfront
Copy link
Contributor

Allowing .separator to grow in width but "respect" widths of sibling items.

Fixes #6658

mcc topbar item

Signed-off-by: Alex Andreev alex.andreev.email@gmail.com

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront added bug Something isn't working area/ui labels Dec 6, 2022
@aleksfront aleksfront added this to the 6.2.5 milestone Dec 6, 2022
@aleksfront aleksfront requested a review from a team as a code owner December 6, 2022 09:51
@aleksfront aleksfront requested review from Iku-turso, ixrock and jim-docker and removed request for a team December 6, 2022 09:51
@aleksfront aleksfront merged commit 667a978 into master Dec 6, 2022
@aleksfront aleksfront deleted the fix-topbar-separator-flex-basis branch December 6, 2022 12:07
@jim-docker jim-docker mentioned this pull request Dec 6, 2022
jim-docker pushed a commit that referenced this pull request Dec 6, 2022
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
jim-docker added a commit that referenced this pull request Dec 6, 2022
* Release 6.2.5

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>

* Bump electron from 19.1.8 to 19.1.9 (#6686)

Bumps [electron](https://github.com/electron/electron) from 19.1.8 to 19.1.9.
- [Release notes](https://github.com/electron/electron/releases)
- [Changelog](https://github.com/electron/electron/blob/main/docs/breaking-changes.md)
- [Commits](electron/electron@v19.1.8...v19.1.9)

---
updated-dependencies:
- dependency-name: electron
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Fix race conditrion preventing window from opening (#6680)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix: remove excessive scrollbars from the TabLayout view (#6689)

* Remove excessive scrollbars from the TabLayout view

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Updating snapshots

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Updating snapshots harder

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

* Fix not being able to add custom helm repos (#6692)

* Add missing safety checks in unit tests for structured clone issues

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix not being able to add custom helm repos

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix crash in PersistentVolumeDetails (#6691)

Signed-off-by: Sebastian Malton <sebastian@malton.name>

Signed-off-by: Sebastian Malton <sebastian@malton.name>

* Fix top-bar .separator width (#6706)

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>

Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Sebastian Malton <sebastian@malton.name>
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sebastian Malton <sebastian@malton.name>
Co-authored-by: Alex Andreev <alex.andreev.email@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lens 2022.11.251411-latest broke extension top bar item layout
2 participants