Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promovicz patches #56

Merged
merged 5 commits into from
Jan 21, 2021
Merged

Promovicz patches #56

merged 5 commits into from
Jan 21, 2021

Conversation

RaymiiOrg
Copy link
Collaborator

Relevant commits as in issue #55 . Skipped over the parenthesis and std::string, due to not being a warning now and the std::string static storage could throw an exception.

@RaymiiOrg RaymiiOrg mentioned this pull request Jan 21, 2021
Closed
lenticularis39
lenticularis39 approved these changes Jan 21, 2021
View reviewed changes
Copy link
Owner

@lenticularis39 lenticularis39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. I did some integer type changes myself at the beginning of the fork, but didn't check for the mismatch extensively, so I fixed it only at places where the compiler complained.

@lenticularis39 lenticularis39 merged commit 3c7b9e4 into lenticularis39:main Jan 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenticularis39 lenticularis39 lenticularis39 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RaymiiOrg @lenticularis39