Fix(#162): DisconnectOnIdle doesn't restore presence
#319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes a problem which caused
DisconnectOnIdleoption to never re-connect RPC after disconnecting due to some refactoring that happened in the extension shortly after I implemented the option.Instead of calling
.disable(), I modifiedcheckCanSendto disallow presence when idling if the option is enabled. A subtle improvement to how timer resets after idling was also needed.Additionally to this, I added some explanations on what idle-related settings do exactly, as they sounded kinda similar and it wasn't clear what they did exactly.
VSCord.mp4