Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: elapsed time #81

Merged
merged 2 commits into from
Aug 7, 2022
Merged

fix: elapsed time #81

merged 2 commits into from
Aug 7, 2022

Conversation

xhayper
Copy link
Collaborator

@xhayper xhayper commented Aug 3, 2022

fix: @types/vscode and engines.vscode version mismatch
ref: #80 (comment)

@xhayper
fix: elapsed time
a2ba9a4 
fix: @types/vscode and engines.vscode version mismatch
ref: #80 (comment)
@xhayper
Copy link
Collaborator Author

xhayper commented Aug 3, 2022

Asking @Sominemo for review and testing.

Sominemo
Sominemo approved these changes Aug 7, 2022
View reviewed changes
Copy link
Contributor

@Sominemo Sominemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for a long delay. Just tested, looking great!

@xhayper
Copy link
Collaborator Author

xhayper commented Aug 7, 2022

@leonardssh I think we are ready for this PR.

@leonardssh leonardssh merged commit c71ba71 into leonardssh:main Aug 7, 2022
@xhayper xhayper deleted the patch-1 branch August 7, 2022 17:22
@xhayper xhayper added the enhancement New feature or request label Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardssh leonardssh leonardssh approved these changes

@Sominemo Sominemo Sominemo approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xhayper @Sominemo @leonardssh