Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misc. fixes for pick() and "when this sprite clicked" #173

Merged
merged 1 commit into from
Mar 11, 2023

Conversation

towerofnix
Copy link
Member

Fixes #164 and the "when this sprite clicked" generally not functioning at all.

This is basically a hand-picked cherry basket from #146, where the same fixes are made across several commits (of debugging). Thanks to @adroitwhiz for figuring out most of this!

This is a quick patch PR so we can release this fix sooner.

@towerofnix towerofnix requested a review from adroitwhiz March 11, 2023 00:50
@towerofnix
Copy link
Member Author

towerofnix commented Mar 11, 2023

@adroitwhiz I'm not sure whether you prefer to merge or rebase, but since all these fixes are already implemented in #164, you should be able to just keep all of your changes and none of these when merging/rebasing and have everything work OK. I hope! My git-fu isn't quite thorough enough :P

I've tested this all works correctly so just getting your code review on principle. Lemme know if there's something obvious I missed 📦

@towerofnix
Copy link
Member Author

Totally reviewed. Yus.

@towerofnix towerofnix merged commit 6eef1f5 into leopard-js:master Mar 11, 2023
@towerofnix towerofnix deleted the when-sprite-clicked-fixes branch March 11, 2023 00:56
@towerofnix towerofnix removed the request for review from adroitwhiz March 11, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broadcast/receive not working?
1 participant