Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exports for CSSClasses and ThemeOptions #110

Closed
niloysikdar opened this issue Sep 11, 2022 · 1 comment · Fixed by #111
Closed

Fix exports for CSSClasses and ThemeOptions #110

niloysikdar opened this issue Sep 11, 2022 · 1 comment · Fixed by #111
Assignees
@niloysikdar
Labels
GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released

Comments

@niloysikdar
Copy link
Member

Description:

While creating one demo application and layout using our package in TypeScript, I realized that we need CSSClasses and ThemeOptions interfaces to declare types for the variables.

Solution:

We need to export these interfaces directly from the package so that users can use them.
@niloysikdar niloysikdar self-assigned this Sep 11, 2022
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Sep 11, 2022
niloysikdar added a commit that referenced this issue Sep 11, 2022
@niloysikdar
fix(exports): add missing exports
8f6ffd8 
Add missing interface exports for CSSClasses and ThemeOptions from the package

Fixes #110

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar mentioned this issue Sep 11, 2022
Merged
agentmilindu pushed a commit that referenced this issue Sep 11, 2022
@niloysikdar
fix(exports): add missing exports (#111)
ca059c4 
Add missing interface exports for CSSClasses and ThemeOptions from the package

Fixes #110

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
github-actions bot pushed a commit that referenced this issue Sep 11, 2022
@semantic-release-bot
chore(release): 1.15.2 [skip ci]
a9582b3 
## [1.15.2](v1.15.1...v1.15.2) (2022-09-11)

### Bug Fixes

* **exports:** add missing exports ([#111](#111)) ([ca059c4](ca059c4)), closes [#110](#110)
@github-actions
Copy link

🎉 This PR is included in version 1.15.2 🎉

@niloysikdar niloysikdar moved this to Done in React Email Sep 12, 2022
@niloysikdar niloysikdar moved this from Done to Released in React Email Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released
Projects
React Email
Status: Released
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(exports): add missing exports leopardslab/react-email
1 participant
@niloysikdar