Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding styling methods #20

Closed
niloysikdar opened this issue Jun 16, 2022 · 0 comments · Fixed by #30
Closed

Adding styling methods #20

niloysikdar opened this issue Jun 16, 2022 · 0 comments · Fixed by #30
Assignees
@niloysikdar
Labels
5 5 story points GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022
Milestone
GSoC 2022 - Sprint B

Comments

@niloysikdar
Copy link
Member

niloysikdar commented Jun 16, 2022 •
edited
Loading

Description:

  1. We can implement a utility method to combine styles, and a hook for exposing styles to components with style overrides.

Outcome:

  1. “sx” method will be implemented
  2. A makeStyles() util which gives useStyles() hook will be implemented
  3. Add a separate section for Utils in Storybook
  4. Add stories for styling like stylx, makeStyles and useStyles.
    • Use the Email component to override style.
@niloysikdar niloysikdar moved this to Todo in React Email Jun 16, 2022
@niloysikdar niloysikdar self-assigned this Jun 16, 2022
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Jun 16, 2022
@agentmilindu agentmilindu added the 5 5 story points label Jun 16, 2022
@niloysikdar niloysikdar moved this from Todo to In Progress in React Email Jun 23, 2022
niloysikdar added a commit that referenced this issue Jun 24, 2022
@niloysikdar
feat(styling): add sx method
1042629 
add sx method to combine stylings

resolves #20

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
niloysikdar added a commit that referenced this issue Jun 24, 2022
@niloysikdar
feat(styling): add makeStyles
9fe1501 
add makeStyles which exposes a useStyles hook with mergeDeep function

resolves #20

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar mentioned this issue Jun 24, 2022
Merged
niloysikdar added a commit that referenced this issue Jun 26, 2022
@niloysikdar
fix(styling): improved and fixed makeStyles
6b9892b 
improved the mergeStyles function and made changes to the makeStyles accordingly

resolves #20

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
Repository owner moved this from In Progress to Done in React Email Jun 26, 2022
github-actions bot pushed a commit that referenced this issue Jun 29, 2022
@semantic-release-bot
chore(release): 1.0.0 [skip ci]
5f1ac1a 
# 1.0.0 (2022-06-29)

### Bug Fixes

* **.npmignore:** add .npmignore ([c0624d7](c0624d7))
* **code style:** fix code style ([f1c35fb](f1c35fb))
* **commitlint:** typescript migration ([57e3f8a](57e3f8a))
* **directory:** fix folder structure ([e35c6ff](e35c6ff))
* **email component:** add return type ([00e2763](00e2763))
* **email component:** fixed issues in Email component ([08162bd](08162bd))
* **email story:** change format ([a86e62b](a86e62b))
* **folder:** fix folder structure ([2930894](2930894))
* **generateemail:** fix generateEmail ([15f2f35](15f2f35))
* **package.json:** remove the empty dependencies part from package.json ([74c82d8](74c82d8))
* **semantic-release/github:** fix addReleases option ([858829b](858829b))
* **storybook:** fix Email story issues ([20b17f2](20b17f2))
* **styling:** fix styling ([b64e88e](b64e88e))
* **styling:** improved and fixed makeStyles ([6b9892b](6b9892b)), closes [#20](#20)

### Features

* add ESLint ([b645c9d](b645c9d))
* add prettier ([1de855a](1de855a))
* **add storybook:** add storybook to the project ([5d9f3fd](5d9f3fd))
* **email component:** add Email component ([a1aafce](a1aafce)), closes [#17](#17)
* **generateEmail:** add generateEmail ([9fc2bda](9fc2bda)), closes [#21](#21)
* **semantic-release:** add semantic-release ([4ac01d9](4ac01d9)), closes [#16](#16)
* **storybook:** add story ([17e9606](17e9606))
* **storybook:** add story ([d63f627](d63f627))
* **storybook:** add story ([e37b1d3](e37b1d3)), closes [#18](#18)
* **styling:** add makeStyles ([9fe1501](9fe1501)), closes [#20](#20)
* **styling:** add sx method ([1042629](1042629)), closes [#20](#20)

### Performance Improvements

* **husky:** add yarn test ([1b4d91f](1b4d91f))

### BREAKING CHANGES

* **styling:** named argument pass for useStyles

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@agentmilindu agentmilindu moved this from Done to Released in React Email Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
5 5 story points GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022
Projects
React Email
Status: Released
Milestone
GSoC 2022 - Sprint B
Development

Successfully merging a pull request may close this issue.

feat(styling): add styling methods leopardslab/react-email
2 participants
@agentmilindu @niloysikdar