Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for ESM #70

Closed
niloysikdar opened this issue Aug 6, 2022 · 1 comment · Fixed by #78
Closed

Support for ESM #70

niloysikdar opened this issue Aug 6, 2022 · 1 comment · Fixed by #78
Assignees
@niloysikdar
Labels
bug Something isn't working GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released
Milestone
GSoC 2022 - Sprint H

Comments

@niloysikdar
Copy link
Member

Description:

  • Currently, our package isn't compatible with the ECMAScript modules standard for the Node.js environment. That means, we can't use the import/export syntax for Node.js.

Outcome:

  • Fixing bugs and adding support for ESM inside Node.js
@niloysikdar niloysikdar added the bug Something isn't working label Aug 6, 2022
@niloysikdar niloysikdar moved this to Todo in React Email Aug 6, 2022
@niloysikdar niloysikdar added the GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 label Aug 6, 2022
@niloysikdar niloysikdar added this to the GSoC 2022 - Sprint H milestone Aug 6, 2022
@niloysikdar niloysikdar moved this from Todo to In Progress in React Email Aug 6, 2022
niloysikdar added a commit that referenced this issue Aug 6, 2022
@niloysikdar
fix(package.json): fix exports map
4c88bda 
Fix bugs and add support for ESM inside Node.js

Resolves #70

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
@niloysikdar niloysikdar mentioned this issue Aug 6, 2022
Merged
@niloysikdar niloysikdar self-assigned this Aug 6, 2022
agentmilindu pushed a commit that referenced this issue Aug 7, 2022
@niloysikdar
fix(package.json): fix exports map (#78)
0716cb0 
Fix bugs and add support for ESM inside Node.js

Resolves #70

Signed-off-by: Niloy Sikdar <niloysikdar30@gmail.com>
Repository owner moved this from In Progress to Done in React Email Aug 7, 2022
github-actions bot pushed a commit that referenced this issue Aug 7, 2022
@semantic-release-bot
chore(release): 1.7.1 [skip ci]
63e36eb 
## [1.7.1](v1.7.0...v1.7.1) (2022-08-07)

### Bug Fixes

* **package.json:** fix exports map ([#78](#78)) ([0716cb0](0716cb0)), closes [#70](#70)
@github-actions
Copy link

github-actions bot commented Aug 7, 2022

🎉 This PR is included in version 1.7.1 🎉

@agentmilindu agentmilindu moved this from Done to Released in React Email Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@niloysikdar niloysikdar

Labels
bug Something isn't working GSoC 2022 Issues and Pull Requests under Google Summer of Code 2022 released
Projects
React Email
Status: Released
Milestone
GSoC 2022 - Sprint H
Development

Successfully merging a pull request may close this issue.

fix(package.json): fix exports map leopardslab/react-email
1 participant
@niloysikdar