Fixing github workflow build and linter #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
The build is failing because of the deprecated github workflow, it try to install a program that requires a newer version of go and it does not work
What I did here:
.gitignore
by one generated by community that include more annoying itemsThe original code uses the golint program that is currently deprecated. If we try to run it, we have the following error:
stmt.go:807:25: exported method NewRow returns unexported type sqlf.newRow, which can be annoying to use
Since I don't know how you want to fix it, I decided to omit the golint action
I would recommend use golangci-lint but if I try to run with the default configuration we got such lint issues:
This linter can be ommited like commant line tool
golangci-lint run --disable=errcheck ./...
, via a golangci-lint configuration file or via a comment like this//nolint:errcheck // explain the reason...
but this should be your choiceQuestions