use savsgio gotils strconv #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello
I know this trick to convert from slice of bytes to string without allocation, used a lot in fasthttp and other projects,
https://groups.google.com/g/Golang-Nuts/c/ENgbUzYvCuU/m/90yGx7GUAgAJ
however, since go 1.2O things changed and many projects had to update using build tags based on go version. The package github.com/savsgio/gotils/strconv already did it for us
I think this can be a safe alternative to this project
BTW, on dialect.go there is another usage of unsafe package with atomic.StorePointer. Today the recommentatios is to use atomic.Pointer but it requires go 1.19
And I think this could be a great code improvement, maybe I can add it on a separated PR