Fix: gh pages deployment w/ custom domain #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you very much! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've re-written the deploy script to use the newer method of deploying to Github Pages (via a gh action directly, instead of from a 'gh-pages' git branch).
I've tested the gh pages deployment with a custom domain on a different repo; I updated the book and the custom domain still works - so we should be good from here on out with this new script.
**
This fix requires you to go to the book's github repo, then click "Settings" > "Pages" and set the "Source" to 'Github Actions' (instead of 'Deploy from a branch').
**
This PR should resolve #9