Replace ouroboros with self_cell #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't really understand what could be the failure in Verify Examples. |
Unrelated to your PR, more general issue across the board (related to a cargo-leptos and lightningcss versioning issue last I checked). |
|
Thanks for keeping track of this, and it looks good to me. |
14 tasks
gbj
pushed a commit
that referenced
this pull request
Jun 14, 2023
maccesch
pushed a commit
to maccesch/leptos
that referenced
this pull request
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
someguynamedjosh/ouroboros#88 suggests
self_cellin place ofouroboros. These things can be tricky. The iterator-based algorithm itself is still good.