Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(workflows): extract calls #1566

Merged
merged 5 commits into from
Aug 23, 2023
Merged

refactor(workflows): extract calls #1566

merged 5 commits into from
Aug 23, 2023

Conversation

agilarity
Copy link
Contributor

@agilarity agilarity commented Aug 22, 2023 •
edited
Loading

READY FOR REVIEW

Supports #1543

Changes

  • Extract get-leptos-changed to reduce duplication
  • Extract get-examples-matrix to reduce duplication
  • Rename jobs and steps to improve readability

Verification

  • Simulated leptos source change
  • Check Examples passed
  • Check Stable passed
  • CI checks were properly triggered but failed for a reason not related to the refactoring

@agilarity agilarity mentioned this pull request Aug 22, 2023
Closed
3 tasks
@agilarity agilarity changed the title (WIP) refactor(workflows): extract calls refactor(workflows): extract calls Aug 22, 2023
@gbj gbj merged commit 3517010 into leptos-rs:main Aug 23, 2023
9 checks passed
@gbj
Copy link
Collaborator

gbj commented Aug 23, 2023

Looks good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agilarity @gbj