Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add autofix.ci to address formatting issues and possible clippy fixes #3235

Merged
merged 4 commits into from
Nov 12, 2024

Conversation

sabify
Copy link
Contributor

@sabify sabify commented Nov 12, 2024

No description provided.

@autofix-troubleshooter
Copy link

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@benwis
Copy link
Contributor

benwis commented Nov 12, 2024

I love the idea of this, but I'm somewhat torn because it's got a very small number of installs.

@sabify
Copy link
Contributor Author

sabify commented Nov 12, 2024

I believe we are giving it read access. I don't understand the installs counter shown in github apps, but some pretty big repos are using it (from https://github.com/autofix-ci/action/network/dependents):

https://github.com/jdx/mise/blob/main/.github/workflows/autofix.yml
https://github.com/rolldown/rolldown/blob/main/.github/workflows/autofix.yml
https://github.com/react-navigation/react-navigation/blob/main/.github/workflows/autofix.yml
and ...

@benwis
Copy link
Contributor

benwis commented Nov 12, 2024

That makes me feel better. We can give it a shot

@benwis benwis merged commit d4044cd into leptos-rs:main Nov 12, 2024
73 of 74 checks passed
@sabify
Copy link
Contributor Author

sabify commented Nov 12, 2024

Cool! Have you installed it on this repo?

Hi! I'm the autofix logoautofix.ci troubleshooter bot.

It looks like you correctly set up a CI job that uses the autofix.ci GitHub Action, but the autofix.ci GitHub App has not been installed for this repository. This means that autofix.ci unfortunately does not have the permissions to fix this pull request. If you are the repository owner, please install the app and then restart the CI workflow! 😃

@benwis
Copy link
Contributor

benwis commented Nov 12, 2024 via email

@sabify
Copy link
Contributor Author

sabify commented Nov 12, 2024

https://github.com/leptos-rs/leptos/runs/32883145624

There should be permission issue here that it can not open PR for the fix.

@benwis
Copy link
Contributor

benwis commented Nov 12, 2024

Github isn't that granular. It has the permissions it asked for and I can't give it more

@sabify
Copy link
Contributor Author

sabify commented Nov 12, 2024

Ooops! Changes cannot be applied to the main branch as we don't give it write permission and it will not open PRs for that.

We have three options here:

  1. Give it write access to apply changes.
  2. Comment out running on the main branch. Will run only on PRs.
  3. Just leave it as it is to acknowledge that there may be some issues in the codebase with the clippy and rustfmt.

@benwis
Copy link
Contributor

benwis commented Nov 12, 2024

I think running only on PRs makes sense here, that's the real pain point anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants