Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap stable feature with nightly and empty feature set testing #591

Closed
wants to merge 8 commits into from

Conversation

remkop22
Copy link
Contributor

@remkop22 remkop22 commented Feb 27, 2023

@gbj I based this branch of your previous work here #571.

I found out by some trial and error that specifying an empty set [] in skip_feature_sets actually skips the empty set 🤯.

I also added a separate test that tests all non-doc-tests with an empty feature set on a stable compiler. This should at least verify that Leptos works as it should on stable without additional feature flags.

Also added feature flags to the integration libraries (@gbj If you have reasons to dislike this due to breakage I'll happily remove it).

@remkop22 remkop22 changed the title Cargo hack Nightly feature and empty feature set testing Feb 27, 2023
@remkop22 remkop22 changed the title Nightly feature and empty feature set testing swap stable feature with nightly and empty feature set testing Feb 27, 2023
@remkop22 remkop22 changed the base branch from nightly-feature to main February 28, 2023 10:22
@gbj
Copy link
Collaborator

gbj commented Mar 3, 2023

Thanks — This is great to know, and seems really helpful. One thing that would also be good would be to remove "csr" from the default features for leptos, so that people need to opt in to CSR and not opt out. This would mean people don't automatically do default-features = false for SSR and then have to opt back in to nightly.

I'm happy to schedule this for some upcoming 0.3 when we're reading to make breaking changes.

@gbj gbj added the 0.3.0 label Mar 3, 2023
@gbj gbj mentioned this pull request Jun 5, 2023
14 tasks
@gbj
Copy link
Collaborator

gbj commented Jun 23, 2023

I started this over in #1227, and just migrtaed all the tests over to work with stable.

@gbj gbj closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants