🐛 fix for "expires_at" / "expires_in" param when "None" is specified #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanitsky
changed the title
|
Thanks |
|
Does it mean we can implement like Gitlab/Doorkeeper is doing and use authlib/OAuth 2 server to provide a custom access token expiration (endless)? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
Description
Some providers provide endless access tokens, therefore, if you specify None for expires_at or expires_in - a token initialization error occurs.
For example, such services are GitHub and Gitlab. Moreover, in the case of the Gitlab, the token for updating is returned, but without expires_at (long-live bug and it won't be fixed, probably).
Links: