Allow falsey but non-None grant uri params #544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are use cases where you want to pass
0
toauthorize_redirect
, for example Auth0 allows you to force login again by passingmax_age=0
, as described here.The current code for
prepare_grant_uri
filters out such parameters. This PR changes that to explicitly filter outNone
instead.What kind of change does this PR introduce? (check at least one)
Does this PR introduce a breaking change? (check one)
Debatable? Technically a breaking change if someone was passing a non-
None
falsey value toauthorize_redirect()
previously.