Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get werkzeug version using importlib #591

Merged
merged 1 commit into from
Dec 17, 2023
Merged

Conversation

Sparrow0hawk
Copy link
Contributor

@Sparrow0hawk Sparrow0hawk commented Oct 27, 2023

Resolves deprecation warning:

.venv/lib/python3.11/site-packages/authlib/integrations/flask_oauth2/errors.py:4: DeprecationWarning: The '__version__' attribute is deprecated and will be removed in Werkzeug 3.1. Use feature detection or 'importlib.metadata.version("werkzeug")' instead.
    _version = werkzeug.__version__.split('.')[0]

DO NOT SEND ANY SECURITY FIX HERE. Please read "Security Reporting" section
on README.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

(If no, please delete the above question and this text message.)


  • You consent that the copyright of your pull request source code belongs to Authlib's author.

@lepture
Copy link
Owner

lepture commented Nov 21, 2023

@Sparrow0hawk tests failed.

@Sparrow0hawk
Copy link
Contributor Author

@lepture please retry, should be fixed.

@azmeuk
Copy link
Collaborator

azmeuk commented Dec 15, 2023

@lepture could there be a 1.2.2 hotfix for this? As the deprecation warning is emitted at the module level, the simple presence of authlib makes it noisy.

@lepture lepture merged commit 2d66702 into lepture:master Dec 17, 2023
8 checks passed
@lepture
Copy link
Owner

lepture commented Dec 17, 2023

@azmeuk 1.3.0 released

@azmeuk
Copy link
Collaborator

azmeuk commented Dec 17, 2023

Thank you @lepture
Did you publish it on pypi? I cannot see 1.3 yet.
https://pypi.org/project/Authlib/#history

@lepture
Copy link
Owner

lepture commented Dec 18, 2023

@azmeuk published on pypi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants