Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #233 (token revocation dosn't work) #289

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lpodkalicki
Copy link

According to http://tools.ietf.org/html/rfc7009 additional endpoint for token revocation should implement client authentication (Basic Auth). It is also expected in oauthlib and cause that error. I have used "request.headers" (not so elegant but the only choice I see at the moment) to pass some information about additional endpoint to extend one condition:

if request.grant_type in grant_types or 'OAUTH2_ADDITIONAL_ENDPOINT' in request.headers:

@RafaelloLollipop
Copy link

Hello folks,
I actually need this feature and I'm thinking about using fork and in the future coming back to master. However to do it i need to be sure that this feature will be in the next update. @lepture I will be very glad if you can confirm it and if it is possible also declare when is planned next release :) I can also help a bit if it will be somehow speed up process.

Great job btw.

@lepture
Copy link
Owner

lepture commented Nov 30, 2016

@VallHer The solution of this PR is not elegant. If you can provide another solution, I'll merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants