Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MarkdownRenderer cleanup #66

Merged
merged 20 commits into from
Jun 21, 2017
Merged

MarkdownRenderer cleanup #66

merged 20 commits into from
Jun 21, 2017

Conversation

Turbo87
Copy link
Contributor

@Turbo87 Turbo87 commented Jun 19, 2017

This PR cleans up the new MarkdownRenderer class introduced by #65

Turbo87 added 20 commits June 19, 2017 10:08
@Turbo87
markdown-renderer: Extract renderContribution() method
78d55c2
@Turbo87
markdown-renderer: Extract renderContributor() method
42f1e18
@Turbo87
markdown-renderer: Extract renderContributorList() method
74b2762
@Turbo87
markdown-renderer: Renamed "headings" to "packageNames"
b77c13c
@Turbo87
markdown-renderer: Move "*" to rendering code
edc8c1c
@Turbo87
markdown-renderer: Initialize "contributionsPrefix" only once
bb73224
@Turbo87
markdown-renderer: Extract commit constants
9297135
@Turbo87
markdown-renderer: Extract renderContributionList() method
80b1b9e
@Turbo87
markdown-renderer: Simplify renderContributionList() method
edd11bb
@Turbo87
markdown-renderer: Move category name rendering further up
82d16ff
@Turbo87
markdown-renderer: Add fast path for single-project repos
17d373f
@Turbo87
Add "single project" functional test
44204b3
@Turbo87
markdown-renderer: Merge duplicate newline renders
925464f
@Turbo87
markdown-renderer: Extract renderPackageNames() method
9c8ca2d
@Turbo87
markdown-renderer/test: Extract renderer() test function
ef4ed8e
@Turbo87
markdown-renderer: Extract renderContributionsByPackage() method
fdc8a18
@Turbo87
markdown-renderer: Extract hasPackages() method
347ea15
@Turbo87
markdown-renderer: Flip if-else
8c3637e
@Turbo87
markdown-renderer: Extract renderRelease() method
73025a8
@Turbo87
markdown-renderer: Remove progress bar
d5d372d 
This part of the script is fast enough
@Turbo87 Turbo87 requested a review from hzoo June 19, 2017 08:11
@Turbo87 Turbo87 merged commit 0de5784 into lerna:master Jun 21, 2017
@Turbo87 Turbo87 deleted the renderer-cleanup branch June 21, 2017 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzoo hzoo hzoo approved these changes

Assignees
No one assigned
Labels
internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Turbo87 @hzoo