Use HTTP-based caching #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of caching the JSON responses forever we will now use https://github.com/zkat/make-fetch-happen for caching which will use proper HTTP caching semantics. This means that even for cached API responses we will do HTTP requests, these requests will have proper cache headers though and likely return 304 responses that don't count towards the request limit on GitHub.
The
cacheDirsetting is still used as before, but the folder layout looks a little different now. Ultimately we should probably remove that option and use the system cache folders instead.tl;dr instead of caching forever we will now be able to see changed PR descriptions or labels while still caching the stuff that hasn't changed 🎉