Fix: Dictionary error in amsmath.vim #2814
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was encountering an error, when loading the plugin. To my understanding, it was in the declaration of the dictionary. Changing it to valid(?) syntax fixed my error.
|
I'm terribly sorry that I've completely forgotten to respond to this PR! I don't understand how that happened! So, your PR is necessary because the syntax I've used depends on the literal dict syntax which was introduced in Vim 8.1.1876. At the time you opened the PR, I should have accepted it since I specifically depended only on version 8.0.1453. However, the version requirement has since been bumped up to 8.2.3995. So, I won't accept this PR now, because I will be using more modern syntaxes and features. However, if you are restricted to use an older Vim version, then I might consider to patch the v2.15 tag. Let me know if this is necessary for you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was encountering an error, when loading the plugin. To my understanding, it was in the declaration of the dictionary. Changing it to valid(?) syntax fixed my error.