Исправить подсчет времени выполнения запросов в батче #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @leshchenko1979 - I've reviewed your changes and they look great!
General suggestions:
- Consider adding comprehensive error handling within the new 'add_throttler_records' method to ensure robustness in face of unexpected JSON structures.
- Simplify the 'add_throttler_records' method to improve code maintainability and readability, potentially by reducing branching logic and focusing on core functionality.
- Review the newly introduced warnings for parameter misuse to ensure they are clear and actionable for the users.
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Docstrings: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Comment on lines
+176
to
+186
| def add_throttler_records(self, method, params: dict, json: dict): | ||
| if "result_time" in json: | ||
| for cmd_name, cmd_url in params["cmd"].items(): | ||
| item_method = cmd_url.split("?")[0] | ||
| item_time = json["result_time"][cmd_name] | ||
| self.method_throttlers[item_method].add_request_record(item_time) | ||
| else: | ||
| request_run_time = json["time"]["operating"] | ||
| self.method_throttlers[method].add_request_record(request_run_time) | ||
|
|
||
| self.leaky_bucket_throttler.add_request_record() |
There was a problem hiding this comment.
suggestion (edge_case_not_handled): Ensure error handling in 'add_throttler_records' method.
Given the critical nature of throttling in API interactions, consider adding error handling within 'add_throttler_records' to manage unexpected 'json' structures or missing keys.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #230 +/- ##
==========================================
- Coverage 89.50% 88.68% -0.82%
==========================================
Files 11 11
Lines 581 592 +11
==========================================
+ Hits 520 525 +5
- Misses 61 67 +6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.