Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Добавить параметр для отключения SSL в конструкторе #233

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

leshchenko1979
Copy link
Owner

Fixes #232

Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @leshchenko1979 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟢 General issues: all looks good
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good
  • 🟢 Docstrings: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

tests/test_srh.py Show resolved Hide resolved
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 88.72%. Comparing base (2404226) to head (5975ee3).

Files Patch % Lines
fast_bitrix24/srh.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #233      +/-   ##
==========================================
+ Coverage   88.70%   88.72%   +0.01%     
==========================================
  Files          11       11              
  Lines         593      594       +1     
==========================================
+ Hits          526      527       +1     
  Misses         67       67              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leshchenko1979 leshchenko1979 merged commit fff1c4b into master Mar 29, 2024
10 of 11 checks passed
@leshchenko1979 leshchenko1979 deleted the leshchenko1979/issue232 branch March 29, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Добавить параметр для отключения SSL в конструкторе
1 participant