Создавать копию объекта params в UserRequestAbstract #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reviewer's Guide by SourceryThis pull request addresses issue #238 by modifying the UserRequestAbstract class in the fast_bitrix24/user_request.py file. The change ensures that the params object is copied during initialization, preventing any unintended side effects from external modifications to the original params object. File-Level Changes
Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @leshchenko1979 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
fast_bitrix24/user_request.py
Outdated
| @@ -52,7 +52,7 @@ def __init__( | |||
|
|
|||
| # st_params будет использоваться для проверки параметров, | |||
| # но на сервер должны уходить параметры без изменения регистра | |||
| self.params = params | |||
| self.params = params.copy() | |||
There was a problem hiding this comment.
issue: Consider handling the case where params is None.
If params can be None, calling params.copy() will raise an AttributeError. It might be safer to add a check or default to an empty dictionary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #238
Summary by Sourcery
This pull request addresses a bug by ensuring that the 'params' object is copied in the 'UserRequestAbstract' class to prevent unintended modifications to the original object.