Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Less silently fails on parsing jQuery UI Datepicker CSS #826

Closed
ghost opened this issue Jun 6, 2012 · 7 comments
Closed

Less silently fails on parsing jQuery UI Datepicker CSS #826

ghost opened this issue Jun 6, 2012 · 7 comments

Comments

@ghost
Copy link

ghost commented Jun 6, 2012

Less 1.3 silently fails on processing jquery.ui.datepicker.css from jQuery UI 1.8.20. The section that causes the problem is:

/* IE6 IFRAME FIX (taken from datepicker 1.5.3 _/
.ui-datepicker-cover {
display: none; /sorry for IE5/
display/__/: block; /sorry for IE5/
position: absolute; /must have/
z-index: -1; /must have/
filter: mask(); /must have/
top: -4px; /must have/
left: -4px; /must have/
width: 200px; /must have/
height: 200px; /_must have*/
}

Normally I wouldn't run this file through Less, however I have my reasons in this case.

@ghost
Copy link
Author

ghost commented Jun 6, 2012

Seems to be the line:

display/_/: block; /_sorry for IE5/

@ghost
Copy link
Author

ghost commented Jun 6, 2012

Fail was in client side processing in Chrome 19.0 on Windows 2008. Less works without the naughty line.

lukeapage added a commit that referenced this issue Aug 12, 2012
@lukeapage
Copy link
Member

Any chance you can retest with the latest source? I've added a test and this works fine in lessc.. if its browser only there are a few specific bugs about browser specific error-reporting and this may be a duplicate of one of those.

@dmcass
Copy link
Contributor

dmcass commented Aug 13, 2012

Confirmed error is showing properly with latest, although the test is slightly off (markdown in the comment system is messing up their code snippets).

display/**/: block; /*sorry for IE5*/

I think the real issue here is that the perfectly valid comment between the rule name and the colon is causing less to choke.

@lukeapage
Copy link
Member

I looked at implementing this, but it would be a hassle - does anyone care any more?

@seven-phases-max
Copy link
Member

I guess if it's really necessary to pass such code through Less then just:

@import (inline) "the-not-less-compatible.css"; 

can do the trick.

SomMeri pushed a commit to SomMeri/less-rhino.js that referenced this issue Aug 27, 2014
* in @Keyframe declaration less#2059,
* after rule name before semicolon less#826.

The comments are eaten instead of being printed into output, but it is
better then crashing on them.
@SomMeri
Copy link
Member

SomMeri commented Aug 31, 2014

Fixed.

@SomMeri SomMeri closed this as completed Aug 31, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants